Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14471] Fix PytestUnknownMarkingWarning #17825

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Jun 3, 2022

  • Fix PytestUnknownMarkingWarning seen in pytest result

  • Also fix a backslash warning apearing nearby in log

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Add a link to the appropriate issue in your description, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented Jun 3, 2022

Can one of the admins verify this patch?

2 similar comments
@asf-ci
Copy link

asf-ci commented Jun 3, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Jun 3, 2022

Can one of the admins verify this patch?

* Fix PytestUnknownMarkingWarning seen in pytest result

* Also fix a backslash warning apearing nearby in log
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #17825 (45a80f7) into master (937e22f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #17825   +/-   ##
=======================================
  Coverage   74.08%   74.09%           
=======================================
  Files         697      697           
  Lines       91986    91986           
=======================================
+ Hits        68146    68153    +7     
+ Misses      22591    22584    -7     
  Partials     1249     1249           
Flag Coverage Δ
python 83.75% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eam/runners/portability/fn_api_runner/execution.py 92.44% <0.00%> (-0.65%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 88.94% <0.00%> (-0.16%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.54% <0.00%> (+0.12%) ⬆️
sdks/python/apache_beam/transforms/util.py 96.22% <0.00%> (+0.15%) ⬆️
...che_beam/runners/interactive/interactive_runner.py 91.39% <0.00%> (+1.32%) ⬆️
...ks/python/apache_beam/runners/worker/data_plane.py 89.26% <0.00%> (+1.69%) ⬆️
.../python/apache_beam/testing/test_stream_service.py 92.85% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 937e22f...45a80f7. Read the comment docs.

@Abacn Abacn marked this pull request as ready for review June 3, 2022 01:55
@Abacn
Copy link
Contributor Author

Abacn commented Jun 3, 2022

R: @chamikaramj
R: @ihji

@chamikaramj
Copy link
Contributor

LGTM. Thanks.

@chamikaramj chamikaramj merged commit ba57979 into apache:master Jun 6, 2022
@Abacn Abacn deleted the fixpytestwarning branch June 6, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants