[Fixes #18679] Ensure that usage of metrics on a template job reports an error #18905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eports an error Note that the usage of DataflowMetrics with a template job was throwing an NPE due to the direct access of the jobId parameter. I also ensured that getting transform step names was accessed via a method instead of reaching into the object directly.
|
R: @oleg-semenov @pranavbhandari24 This came from a user getting stuck since they were launching a flex template that was creating a classic template which tried to access metrics for a non-existent job and it manifested as an NPE. |
|
LGTM Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the usage of DataflowMetrics with a template job was throwing an NPE due to the direct access of the jobId parameter.
I also ensured that getting transform step names was accessed via a method instead of reaching into the object directly.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.