Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-1369] Reduce test times for two retry based tests #1923

Closed
wants to merge 1 commit into from

Conversation

sb2nov
Copy link
Contributor

@sb2nov sb2nov commented Feb 6, 2017

R: @charlesccychen PTAL

  • The gcsio test was taking 2s so reducing the segment override makes it faster.
  • The retry test now just starts at a lower time to speed it up from 1s -> 0.1s

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 69.685% when pulling d6b9e55 on sb2nov:BEAM-reduce-test-times into b3d962d on apache:master.

@asfbot
Copy link

asfbot commented Feb 6, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7095/
--none--

Copy link
Contributor

@charlesccychen charlesccychen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@sb2nov
Copy link
Contributor Author

sb2nov commented Feb 6, 2017

@aaltay please merge

@asfgit asfgit closed this in d18db93 Feb 6, 2017
@sb2nov sb2nov deleted the BEAM-reduce-test-times branch February 6, 2017 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants