Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount GCP credentials in local docker environments. #19265

Merged
merged 2 commits into from
Jun 6, 2022

Conversation

robertwb
Copy link
Contributor

@robertwb robertwb commented Jun 3, 2022

This allows cross-langauge transforms, such as IOs, to authenticate
as if they were running in process.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Add a link to the appropriate issue in your description, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

This allows cross-langauge transforms, such as IOs, to authenticate
as if they were running in process.
@github-actions github-actions bot added the python label Jun 3, 2022
@robertwb
Copy link
Contributor Author

robertwb commented Jun 3, 2022

R: @johnjcasey

@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #19265 (be4d0c3) into master (f24cedf) will decrease coverage by 0.01%.
The diff coverage is 8.33%.

@@            Coverage Diff             @@
##           master   #19265      +/-   ##
==========================================
- Coverage   74.07%   74.05%   -0.02%     
==========================================
  Files         697      697              
  Lines       91927    91939      +12     
==========================================
- Hits        68092    68086       -6     
- Misses      22590    22608      +18     
  Partials     1245     1245              
Flag Coverage Δ
python 83.71% <8.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nners/portability/fn_api_runner/worker_handlers.py 77.89% <8.33%> (-1.45%) ⬇️
sdks/python/apache_beam/internal/gcp/auth.py 73.33% <0.00%> (-5.34%) ⬇️
.../apache_beam/runners/interactive/dataproc/types.py 93.10% <0.00%> (-3.45%) ⬇️
sdks/python/apache_beam/internal/dill_pickler.py 84.89% <0.00%> (-1.44%) ⬇️
sdks/python/apache_beam/transforms/core.py 92.14% <0.00%> (-0.16%) ⬇️
sdks/python/apache_beam/coders/coders.py 88.22% <0.00%> (-0.13%) ⬇️
sdks/python/apache_beam/ml/inference/pytorch.py
...thon/apache_beam/ml/inference/pytorch_inference.py 0.00% <0.00%> (ø)
...hon/apache_beam/runners/worker/bundle_processor.py 93.54% <0.00%> (+0.24%) ⬆️
...hon/apache_beam/runners/direct/test_stream_impl.py 94.02% <0.00%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f24cedf...be4d0c3. Read the comment docs.

@johnjcasey
Copy link
Contributor

Is there a way to test this?

@robertwb
Copy link
Contributor Author

robertwb commented Jun 6, 2022

I've tested this manually, but there doesn't seem a good way to meaningfully unit test this. It will be depended on by some future cross-language tests though.

@johnjcasey
Copy link
Contributor

Thats sort of what I thought. LGTM, and lets just keep an eye on this until those xlang tests are set up

@robertwb robertwb merged commit 0443136 into apache:master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants