Add an option to run Python operations in-line when invoked as a remote runner. #19266
Conversation
…te runner. This is useful in cases where a Python external transform is used at construction, and then later the pipeline is run locally on the Python runner. Also removes an unnecessary warning as containers are now named according to their Python version.
Codecov Report
@@ Coverage Diff @@
## master #19266 +/- ##
==========================================
- Coverage 74.07% 74.04% -0.03%
==========================================
Files 697 697
Lines 91927 91950 +23
==========================================
- Hits 68092 68088 -4
- Misses 22590 22617 +27
Partials 1245 1245
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
R: @damccorm |
| }) | ||
| def cancel(self): | ||
| if not self.is_terminal_state(self.state): | ||
| self.result.cancel() |
There was a problem hiding this comment.
Are we using this function anywhere/is there a reason to pull this out?
There was a problem hiding this comment.
This overrides/implements the default no-op version at https://github.com/apache/beam/blob/v2.39.0/sdks/python/apache_beam/runners/portability/local_job_service.py#L313
|
Thanks for the quick review! |
This is useful in cases where a Python external transform is used
at construction, and then later the pipeline is run locally on the
Python runner.
Also removes an unnecessary warning as containers are now named
according to their Python version.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.