Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate missing display data for remotely expanded transforms. #19267

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

robertwb
Copy link
Contributor

@robertwb robertwb commented Jun 3, 2022


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Add a link to the appropriate issue in your description, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@robertwb
Copy link
Contributor Author

robertwb commented Jun 3, 2022

R: @chamikaramj

@github-actions github-actions bot added the python label Jun 3, 2022
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #19267 (93002d6) into master (f24cedf) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19267   +/-   ##
=======================================
  Coverage   74.07%   74.07%           
=======================================
  Files         697      697           
  Lines       91927    91927           
=======================================
+ Hits        68092    68093    +1     
+ Misses      22590    22589    -1     
  Partials     1245     1245           
Flag Coverage Δ
python 83.73% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/transforms/external.py 79.84% <ø> (ø)
sdks/python/apache_beam/internal/dill_pickler.py 84.89% <0.00%> (-1.44%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 92.44% <0.00%> (-0.65%) ⬇️
sdks/python/apache_beam/transforms/core.py 92.14% <0.00%> (-0.16%) ⬇️
sdks/python/apache_beam/coders/coders.py 88.22% <0.00%> (-0.13%) ⬇️
sdks/python/apache_beam/ml/inference/pytorch.py
...thon/apache_beam/ml/inference/pytorch_inference.py 0.00% <0.00%> (ø)
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.09% <0.00%> (+0.15%) ⬆️
...hon/apache_beam/runners/worker/bundle_processor.py 93.54% <0.00%> (+0.24%) ⬆️
sdks/python/apache_beam/runners/direct/executor.py 97.01% <0.00%> (+0.54%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f24cedf...93002d6. Read the comment docs.

@robertwb
Copy link
Contributor Author

robertwb commented Jun 6, 2022

Unrelated failure in apache_beam.runners.portability.fn_api_runner.fn_runner_test.FnApiRunnerTestWithGrpcAndMultiWorkers.test_batch_pardo_trigger_flush

@robertwb
Copy link
Contributor Author

robertwb commented Jun 6, 2022

Run Python PreCommit

@chamikaramj
Copy link
Contributor

LGTM. Thanks.

@robertwb robertwb merged commit 88fc2ea into apache:master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants