Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-59] Beam GcsFileSystem: implementation of match(). #2022

Closed
wants to merge 2 commits into from

Conversation

peihe
Copy link
Contributor

@peihe peihe commented Feb 16, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

This PR is based on #2015

@peihe
Copy link
Contributor Author

peihe commented Feb 16, 2017

R: @dhalperi for commit d88f8d6
CC: @tgroh

Will rebase once #2015 is LGTMed and merged.

@asfbot
Copy link

asfbot commented Feb 16, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7482/

Build result: FAILURE

[...truncated 5406 lines...] at hudson.remoting.UserRequest.perform(UserRequest.java:153) at hudson.remoting.UserRequest.perform(UserRequest.java:50) at hudson.remoting.Request$2.run(Request.java:332) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745)Caused by: org.apache.maven.plugin.MojoFailureException: You have 1 Checkstyle violation. at org.apache.maven.plugin.checkstyle.CheckstyleViolationCheckMojo.execute(CheckstyleViolationCheckMojo.java:588) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) ... 31 more2017-02-16T19:44:59.476 [ERROR] 2017-02-16T19:44:59.476 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-02-16T19:44:59.476 [ERROR] 2017-02-16T19:44:59.476 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-02-16T19:44:59.476 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException2017-02-16T19:44:59.477 [ERROR] 2017-02-16T19:44:59.477 [ERROR] After correcting the problems, you can resume the build with the command2017-02-16T19:44:59.477 [ERROR] mvn -rf :beam-sdks-java-io-google-cloud-platformchannel stoppedSetting status of d88f8d6 to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7482/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 69.268% when pulling abe5462 on peihe:file-system-gs-match into 817688a on apache:master.

@asfbot
Copy link

asfbot commented Feb 16, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7483/
--none--

@peihe
Copy link
Contributor Author

peihe commented Feb 16, 2017

PTAL
rebased

return MatchResult.create(Status.ERROR, e);
}
}})
.toList();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume we will eventually want to BULK or at least parallelize this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming I'm right, can you please file a JIRA and put a TODO here (and on MatchNonGlobs?) ?

Copy link
Contributor

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 2c9babb on peihe:file-system-gs-match into ** on apache:master**.

@asfbot
Copy link

asfbot commented Feb 17, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7500/
--none--

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 69.275% when pulling 2c9babb on peihe:file-system-gs-match into 9151676 on apache:master.

@asfbot
Copy link

asfbot commented Feb 17, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7504/
--none--

@dhalperi
Copy link
Contributor

Still LGTM, merged now.

@asfgit asfgit closed this in 9df1da4 Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants