Update all links to in progress jiras to issues #21749

damccorm · 2022-06-08T15:10:05Z

This was driven by a script that uses the mapping generated during the jira -> GH Issues migration. It takes all Jira links that aren't in CHANGES.md or the blog and maps them to the corresponding issue. This may not be comprehensive, but it moves the large majority of issues and helps set that as the standard going forward.

I'd recommend doing an audit review of this rather than going line by line. I did a full line by line review and caught a few string issues, but for the most part the tool did its job.

Part of #21686

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Choose reviewer(s) and mention them in a comment (R: @username).
Add a link to the appropriate issue in your description, if applicable. This will automatically link the pull request to the issue.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

asf-ci · 2022-06-08T15:10:08Z

Can one of the admins verify this patch?

asf-ci · 2022-06-08T15:10:08Z

Can one of the admins verify this patch?

asf-ci · 2022-06-08T15:10:08Z

Can one of the admins verify this patch?

damccorm · 2022-06-08T16:03:08Z

R: @aijamalnk

codecov · 2022-06-08T16:50:18Z

Codecov Report

Merging #21749 (fe19654) into master (a1c3d0c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21749   +/-   ##
=======================================
  Coverage   74.03%   74.03%           
=======================================
  Files         698      698           
  Lines       92192    92192           
=======================================
  Hits        68252    68252           
  Misses      22689    22689           
  Partials     1251     1251

Flag	Coverage Δ
python	`83.61% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../python/apache_beam/testing/test_stream_service.py	`88.09% <0.00%> (-4.77%)`	⬇️
...che_beam/runners/interactive/interactive_runner.py	`90.06% <0.00%> (-1.33%)`	⬇️
...hon/apache_beam/runners/worker/bundle_processor.py	`93.54% <0.00%> (-0.13%)`	⬇️
sdks/python/apache_beam/runners/common.py	`88.06% <0.00%> (+0.12%)`	⬆️
...eam/runners/portability/fn_api_runner/execution.py	`93.08% <0.00%> (+0.64%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1c3d0c...fe19654. Read the comment docs.

aijamalnk · 2022-06-08T20:55:11Z

sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java

@@ -2086,7 +2086,7 @@ private boolean hasStatementAndSetter() {
  private static class Reparallelize<T> extends PTransform<PCollection<T>, PCollection<T>> {
    @Override
    public PCollection<T> expand(PCollection<T> input) {
-      // See https://issues.apache.org/jira/browse/BEAM-2803
+      // See https://github.com/apache/beam/issues/1796403


This looks wrong / broken

Fixed - thanks!

aijamalnk · 2022-06-08T20:57:49Z

sdks/python/apache_beam/runners/portability/portable_runner.py

@@ -325,7 +325,7 @@ def get_proto_pipeline(pipeline, options):
        default_environment=PortableRunner._create_environment(
            portable_options))

-    # TODO: https://issues.apache.org/jira/browse/BEAM-7199
+    # TODO: https://github.com/apache/beam/issues/181099


this looks broken as well

Fixed - thanks!

aijamalnk · 2022-06-08T20:58:49Z

website/www/site/content/en/contribute/_index.md

@@ -86,7 +86,7 @@ Here’s a list of things you can do to get started contributing:
    <td class="list-text-size-md">
      <ul>
        <li>Follow the website <a href="https://beam.apache.org/contribute/get-started-contributing/">Contribution Guide</a> to make changes yourself.</li>
-        <li>Check our <a href="https://issues.apache.org/jira/browse/BEAM-13229?jql=project%20%3D%20BEAM%20AND%20resolution%20%3D%20Unresolved%20AND%20labels%20%3D%20website%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC">Website Backlog</a> in Jira to find rooms for improvement, or propose one.</li>
+        <li>Check our <a href="https://github.com/apache/beam/issues/21251?jql=project%20%3D%20BEAM%20AND%20resolution%20%3D%20Unresolved%20AND%20labels%20%3D%20website%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC">Website Backlog</a> in Jira to find rooms for improvement, or propose one.</li>


this is not working as expected

Fixed - good catch

aijamalnk · 2022-06-08T21:00:47Z

website/www/site/content/en/documentation/dsls/dataframes/differences-from-pandas.md

@@ -63,7 +63,7 @@ Examples:
 Beam DataFrame operations are deferred, but the schemas of the resulting DataFrames are not, meaning that result columns must be computable without access to the data. Some DataFrame operations can’t support this usage, so they can’t be implemented. These operations raise a [WontImplementError](https://beam.apache.org/releases/pydoc/{{< param release_latest >}}/apache_beam.dataframe.frame_base.html#apache_beam.dataframe.frame_base.WontImplementError).

 <!-- TODO(BEAM-12169): Document the use of categorical columns as a workaround -->
-Currently there’s no workaround for this issue. But in the future, Beam Dataframe may support non-deferred column operations on categorical columns. This work is being tracked in [BEAM-12169](https://issues.apache.org/jira/browse/BEAM-12169).
+Currently there’s no workaround for this issue. But in the future, Beam Dataframe may support non-deferred column operations on categorical columns. This work is being tracked in [BEAM-12169](https://github.com/apache/beam/issues/20958).


here the link text shows the JIRA issue but theaddress links to the github issue. I guess this is fine: [BEAM-12169](https://github.com/apache/beam/issues/20958)

Yeah, I'm not too worried about fixing these types of instances - it doesn't make much of a difference IMO

aijamalnk · 2022-06-08T21:01:25Z

website/www/site/content/en/documentation/patterns/overview.md

@@ -56,7 +56,7 @@ Pipeline patterns demonstrate common Beam use cases. Pipeline patterns are based

 ## Contributing a pattern

-To contribute a new pipeline pattern, create an issue with the [`pipeline-patterns` label](https://issues.apache.org/jira/browse/BEAM-7449?jql=labels%20%3D%20pipeline-patterns) and add details to the issue description. See [Get started contributing](/contribute/) for more information.
+To contribute a new pipeline pattern, create [a feature request](https://github.com/apache/beam/issues/new?assignees=octocat&labels=new+feature%2Cawaiting+triage&template=feature.yml&title=%5BFeature+Request%5D%3A+) and add details to the issue description. See [Get started contributing](/contribute/) for more information.


this looks broken

This one was actually correct, though the octocat piece wasn't needed (it doesn't harm anything though)

aijamalnk · 2022-06-08T21:03:56Z

website/www/site/content/en/roadmap/euphoria.md

@@ -19,7 +19,7 @@ limitations under the License.

 Easy to use Java 8 DSL for the Beam Java SDK. Provides a high-level abstraction of Beam transformations, which is both easy to read and write. Can be used as a complement to existing Beam pipelines (convertible back and forth). You can have a glimpse of the API at [WordCount example](/documentation/sdks/java/euphoria/#wordcount-example).

- JIRA: [dsl-euphoria](https://issues.apache.org/jira/browse/BEAM-4366?jql=project%20%3D%20BEAM%20AND%20component%20%3D%20dsl-euphoria) / [BEAM-3900](https://issues.apache.org/jira/browse/BEAM-3900)
+- JIRA: [dsl-euphoria](https://github.com/apache/beam/issues?q=is%3Aopen+is%3Aissue+label%3Adsl-euphoria) / [BEAM-3900](https://issues.apache.org/jira/browse/BEAM-3900)


this looks broken

It's actually correct

damccorm · 2022-06-08T22:52:53Z

Run Java_Examples_Dataflow_Java11 PreCommit

damccorm · 2022-06-08T22:53:01Z

Run Java PreCommit

aijamalnk · 2022-06-08T23:30:53Z

LGTM merging. Please make sure to address outstanding in follow up.

damccorm added 3 commits June 8, 2022 09:42

Update all links to in progress jiras to issues

8eb9816

Fix some broken links

5ec28ea

Fix some broken links

3255ecf

github-actions bot added amqp aws build cassandra clickhouse core dataflow direct elasticsearch euphoria examples extensions extensions-java flink fn-execution gcp google-cloud-platform-core hadoop hbase hcatalog io jackson java jdbc labels Jun 8, 2022

github-actions bot added sorter spark sql synthetic thrift tika twister2 website xml zetasketch labels Jun 8, 2022

damccorm added 3 commits June 8, 2022 11:23

Spotless format

a4e6643

Spotless apply

b69da5f

One more link

7cc7b0c

aijamalnk reviewed Jun 8, 2022

View reviewed changes

damccorm added 2 commits June 8, 2022 17:27

A few link fixes

72d2137

Wording

fe19654

aijamalnk merged commit 4ffeae4 into apache:master Jun 8, 2022

damccorm deleted the users/damccorm/jiratoghStrings branch June 9, 2022 12:33

This was referenced Jun 9, 2022

More Jira -> Issues doc updates #21770

Merged

[Task]: Update all jira references in the codebase to the migrated issue #21812

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update all links to in progress jiras to issues #21749

Update all links to in progress jiras to issues #21749

damccorm commented Jun 8, 2022 •

edited

asf-ci commented Jun 8, 2022

asf-ci commented Jun 8, 2022

asf-ci commented Jun 8, 2022

damccorm commented Jun 8, 2022

codecov bot commented Jun 8, 2022 •

edited

aijamalnk Jun 8, 2022

damccorm Jun 8, 2022

aijamalnk Jun 8, 2022

damccorm Jun 8, 2022

aijamalnk Jun 8, 2022

damccorm Jun 8, 2022

aijamalnk Jun 8, 2022

damccorm Jun 8, 2022

aijamalnk Jun 8, 2022

damccorm Jun 8, 2022

aijamalnk Jun 8, 2022

damccorm Jun 8, 2022

damccorm commented Jun 8, 2022

damccorm commented Jun 8, 2022

aijamalnk commented Jun 8, 2022

Update all links to in progress jiras to issues #21749

Update all links to in progress jiras to issues #21749

Conversation

damccorm commented Jun 8, 2022 • edited

GitHub Actions Tests Status (on master branch)

asf-ci commented Jun 8, 2022

asf-ci commented Jun 8, 2022

asf-ci commented Jun 8, 2022

damccorm commented Jun 8, 2022

codecov bot commented Jun 8, 2022 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

damccorm commented Jun 8, 2022

damccorm commented Jun 8, 2022

aijamalnk commented Jun 8, 2022

damccorm commented Jun 8, 2022 •

edited

codecov bot commented Jun 8, 2022 •

edited