Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template_location flag to Go Dataflow runner #21774

Merged
merged 3 commits into from
Jun 9, 2022

Conversation

jrmccluskey
Copy link
Contributor

Adds the --template_location flag and uses it to route the serialized job graph to an alternative GCS bucket instead of staging it and submitting the job to Dataflow.

Closes #21773


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Add a link to the appropriate issue in your description, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented Jun 9, 2022

Can one of the admins verify this patch?

2 similar comments
@asf-ci
Copy link

asf-ci commented Jun 9, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Jun 9, 2022

Can one of the admins verify this patch?

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #21774 (157ada1) into master (67533d1) will decrease coverage by 0.00%.
The diff coverage is 9.09%.

@@            Coverage Diff             @@
##           master   #21774      +/-   ##
==========================================
- Coverage   74.03%   74.02%   -0.01%     
==========================================
  Files         698      698              
  Lines       92192    92203      +11     
==========================================
+ Hits        68255    68256       +1     
- Misses      22686    22696      +10     
  Partials     1251     1251              
Flag Coverage Δ
go 50.93% <9.09%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...o/pkg/beam/runners/dataflow/dataflowlib/execute.go 0.00% <0.00%> (ø)
...ks/go/pkg/beam/runners/dataflow/dataflowlib/job.go 21.55% <ø> (ø)
sdks/go/pkg/beam/runners/dataflow/dataflow.go 58.65% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67533d1...157ada1. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2022

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @riteshghorse for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lostluck lostluck merged commit c305fc0 into apache:master Jun 9, 2022
@jrmccluskey jrmccluskey deleted the templateTantrum branch June 15, 2022 18:33
bullet03 pushed a commit to akvelon/beam that referenced this pull request Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add support for the Dataflow template_location flag to the Go SDK
3 participants