Fix every PR linking to PR 123 #21802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abacn
changed the title
|
R: @damccorm |
damccorm
approved these changes
Jun 10, 2022
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -5,7 +5,7 @@ | |||
| Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: | |||
|
|
|||
| - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). | |||
| - [ ] Mention the appropriate issue in your description (for example: "addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment "fixes #<ISSUE NUMBER>" instead. | |||
| - [ ] Mention the appropriate issue in your description (for example: "`addresses #123`"), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment "`fixes #<ISSUE NUMBER>`" instead. | |||
There was a problem hiding this comment.
Suggested change
| - [ ] Mention the appropriate issue in your description (for example: "`addresses #123`"), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment "`fixes #<ISSUE NUMBER>`" instead. | |
| - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead. |
Nit: We probably don't need the quotes anymore
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
LGTM thanks! |
bullet03
pushed a commit
to akvelon/beam
that referenced
this pull request
Jun 20, 2022
* Fix every PR linking to Issue 123 * remove redundant quotation marks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #21686
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123"), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment "fixes #<ISSUE NUMBER>" instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.