Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go SDK: Improve error message when a filesystem scheme is not found #21816

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

gonzojive
Copy link
Contributor

Example old message:

panic: file system scheme "default" not registered

Example new message:

panic: file system scheme "default" not registered for "/tmp/fake.txt": Consider adding the following import to your program to register an implementation for "default":
  import _ "github.com/apache/beam/sdks/v2/go/pkg/beam/io/filesystem/local"

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

…und.

Example old message:

    panic: file system scheme "default" not registered

Example new message:

    panic: file system scheme "default" not registered for "/tmp/fake.txt": Consider adding the following import to your program to register an implementation for "default":
      import _ "github.com/apache/beam/sdks/v2/go/pkg/beam/io/filesystem/local"
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the contribution

@github-actions
Copy link
Contributor

R: @lostluck for final approval

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! A bit of indirect coupling but it's easy enough for us to keep the map up to date if others are created. Thank you for the contribution!

@lostluck lostluck merged commit 986fb40 into apache:master Jun 13, 2022
bullet03 pushed a commit to akvelon/beam that referenced this pull request Jun 20, 2022
…und. (apache#21816)

Example old message:

    panic: file system scheme "default" not registered

Example new message:

    panic: file system scheme "default" not registered for "/tmp/fake.txt": Consider adding the following import to your program to register an implementation for "default":
      import _ "github.com/apache/beam/sdks/v2/go/pkg/beam/io/filesystem/local"
@gonzojive gonzojive deleted the gosdk-diagnostic-fs-errors branch June 25, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants