Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#21853] Adjust Go cross-compile to target entire package #21854

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

youngoli
Copy link
Contributor

Without this change, cross-compilation fails on main packages with multiple files. #21853

This logic was already being applied in the test case but not the general case. Now it is just applied regardless. Instead of targeting a specific main.go file (ex. "foo/main.go") it will now target an entire directory (ex. "foo/.") and get all the other files needed.

Tested manually by running a pipeline with multiple files in the main package on Dataflow.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

This logic was already being applied in the test case but not the general case. Now it is just applied regardless. Instead of targeting a specific main.go file (ex. "foo/main.go") it will now target an entire directory (ex. "foo/.") and get all the other files needed.
@youngoli
Copy link
Contributor Author

R: @lostluck

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #21854 (35b68a6) into master (080f54a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21854   +/-   ##
=======================================
  Coverage   74.09%   74.09%           
=======================================
  Files         698      698           
  Lines       92503    92503           
=======================================
  Hits        68542    68542           
  Misses      22706    22706           
  Partials     1255     1255           
Flag Coverage Δ
go 50.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 080f54a...35b68a6. Read the comment docs.

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@lostluck
Copy link
Contributor

Possibly dumb question: This works even if there are test files for the main package?

@lostluck
Copy link
Contributor

PRobably fine. The tool documentation explicitly says that for compiling a package, the _test.go files are ignored.

@lostluck lostluck merged commit b527ac4 into apache:master Jun 14, 2022
bullet03 pushed a commit to akvelon/beam that referenced this pull request Jun 20, 2022
…he#21854)

This logic was already being applied in the test case but not the general case. Now it is just applied regardless. Instead of targeting a specific main.go file (ex. "foo/main.go") it will now target an entire directory (ex. "foo/.") and get all the other files needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants