Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for RunInference keyed/unkeyed Modelhandler and examples #21856

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

AnandInguva
Copy link
Contributor

@AnandInguva AnandInguva commented Jun 14, 2022

Unit tests

  1. keyed examples and unkeyed Model Handler
  2. Unkeyed examples and keyed model handler

These are used to catch TypeError when wrong input is passed to RunInference.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented Jun 14, 2022

Can one of the admins verify this patch?

4 similar comments
@asf-ci
Copy link

asf-ci commented Jun 14, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Jun 14, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Jun 14, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Jun 14, 2022

Can one of the admins verify this patch?

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #21856 (7d47ebd) into master (7bf822a) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #21856      +/-   ##
==========================================
- Coverage   74.09%   74.07%   -0.03%     
==========================================
  Files         698      698              
  Lines       92503    92524      +21     
==========================================
- Hits        68544    68541       -3     
- Misses      22704    22728      +24     
  Partials     1255     1255              
Flag Coverage Δ
python 83.73% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) ⬇️
sdks/python/apache_beam/io/source_test_utils.py 88.01% <0.00%> (-1.39%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 90.06% <0.00%> (-1.33%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 92.44% <0.00%> (-0.65%) ⬇️
sdks/python/apache_beam/io/hadoopfilesystem.py 97.28% <0.00%> (ø)
...thon/apache_beam/ml/inference/pytorch_inference.py 0.00% <0.00%> (ø)
sdks/python/apache_beam/transforms/core.py 92.39% <0.00%> (+0.01%) ⬆️
.../python/apache_beam/transforms/periodicsequence.py 98.38% <0.00%> (+0.02%) ⬆️
sdks/python/apache_beam/pvalue.py 91.44% <0.00%> (+0.06%) ⬆️
...s/python/apache_beam/testing/synthetic_pipeline.py 82.29% <0.00%> (+0.24%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bf822a...7d47ebd. Read the comment docs.

@AnandInguva
Copy link
Contributor Author

R: @tvalentyn

@tvalentyn
Copy link
Contributor

LGTM, happy to merge when tests pass.

@tvalentyn tvalentyn merged commit dfb6558 into apache:master Jun 15, 2022
prodriguezdefino pushed a commit to prodriguezdefino/beam-pabs that referenced this pull request Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants