Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README documentation for scikit-learn MNIST example #21887

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

yeandy
Copy link
Contributor

@yeandy yeandy commented Jun 15, 2022

Add README for scikit-learn example


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented Jun 15, 2022

Can one of the admins verify this patch?

4 similar comments
@asf-ci
Copy link

asf-ci commented Jun 15, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Jun 15, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Jun 15, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Jun 15, 2022

Can one of the admins verify this patch?

@yeandy
Copy link
Contributor Author

yeandy commented Jun 15, 2022

R: @AnandInguva

@yeandy
Copy link
Contributor Author

yeandy commented Jun 15, 2022

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #21887 (6c5bd4f) into master (b1a313e) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #21887      +/-   ##
==========================================
- Coverage   74.01%   74.01%   -0.01%     
==========================================
  Files         699      699              
  Lines       92675    92675              
==========================================
- Hits        68592    68591       -1     
- Misses      22828    22829       +1     
  Partials     1255     1255              
Flag Coverage Δ
python 83.65% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/io/localfilesystem.py 90.97% <0.00%> (-0.76%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 92.44% <0.00%> (-0.65%) ⬇️
sdks/python/apache_beam/transforms/combiners.py 93.05% <0.00%> (-0.39%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 88.94% <0.00%> (-0.16%) ⬇️
sdks/python/apache_beam/transforms/util.py 96.06% <0.00%> (-0.16%) ⬇️
...examples/inference/pytorch_image_classification.py 0.00% <0.00%> (ø)
...eam/runners/interactive/interactive_environment.py 92.02% <0.00%> (+0.30%) ⬆️
...hon/apache_beam/runners/direct/test_stream_impl.py 94.02% <0.00%> (+0.74%) ⬆️
...che_beam/runners/interactive/interactive_runner.py 91.39% <0.00%> (+1.32%) ⬆️
...python/apache_beam/runners/worker/worker_status.py 79.71% <0.00%> (+1.44%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1a313e...6c5bd4f. Read the comment docs.

@AnandInguva
Copy link
Contributor

LGTM! Thanks Andy.

Reference: Example PR #21781

@yeandy
Copy link
Contributor Author

yeandy commented Jun 15, 2022

Unrelated (go licenses) failures.

@tvalentyn tvalentyn merged commit a742777 into apache:master Jun 15, 2022
prodriguezdefino pushed a commit to prodriguezdefino/beam-pabs that referenced this pull request Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants