Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.40.0] Fix FlatMap numpy array bug #22007

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

TheNeuralBit
Copy link
Member

Cherry-pick #22006 into release branch.

This change fixes a regression introduced in 0de9821, which breaks pipelines that return a numpy array (or any other iterable that has overridden __bool__ to raise an error) in a FlatMap.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@TheNeuralBit
Copy link
Member Author

R: @pabloem

@TheNeuralBit
Copy link
Member Author

Run Python_PVR_Flink PreCommit

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #22007 (92a57ce) into release-2.40.0 (882b608) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@               Coverage Diff               @@
##           release-2.40.0   #22007   +/-   ##
===============================================
  Coverage           73.97%   73.97%           
===============================================
  Files                 702      702           
  Lines               92833    92835    +2     
===============================================
+ Hits                68670    68679    +9     
+ Misses              22908    22901    -7     
  Partials             1255     1255           
Flag Coverage Δ
python 83.58% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/runners/common.py 88.59% <75.00%> (-0.10%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.09% <0.00%> (+0.15%) ⬆️
...hon/apache_beam/runners/worker/bundle_processor.py 93.67% <0.00%> (+0.24%) ⬆️
...che_beam/runners/interactive/interactive_runner.py 91.39% <0.00%> (+1.32%) ⬆️
sdks/python/apache_beam/utils/interactive_utils.py 97.56% <0.00%> (+2.43%) ⬆️
.../python/apache_beam/testing/test_stream_service.py 92.85% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 882b608...92a57ce. Read the comment docs.

@pabloem
Copy link
Member

pabloem commented Jun 22, 2022

LGTM!

@pabloem pabloem merged commit 313f039 into apache:release-2.40.0 Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants