Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pub/Sub Schema Transform Read Provider #22145

Merged

Conversation

damondouglas
Copy link
Contributor

@damondouglas damondouglas commented Jul 3, 2022

This PR address #21412 by implementing a PubSubTransformReadProvider.

Due to repeatedly failing beam_PreCommit_Java tests that have nothing to do with code in this PR (See example), to validate this PR, I ran the following gradle tasks prior to submission. All passed with the exception of ./gradlew sdks:java:io:google-cloud-platform:check that failed due to invalid Google Authentication credentials and only with tests that have nothing to do with code in the PR.

./gradlew rat
./gradlew spotlessCheck
./gradlew sdks:java:io:google-cloud-platform:check
./gradlew sdks:java:io:google-cloud-platform:checkStyleMain
./gradlew sdks:java:io:google-cloud-platform:checkStyleTest

I would like to request the following to review this PR:
R: @pabloem


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@pabloem
Copy link
Member

pabloem commented Jul 6, 2022

Run Java PreCommit

@pabloem
Copy link
Member

pabloem commented Aug 8, 2022

lgtm

@pabloem pabloem merged commit e83ef73 into apache:master Aug 8, 2022
@damondouglas damondouglas deleted the 21412-PubsubSchemaTransformReadProvider branch August 17, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants