Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website] update shortcode languages #22275

Merged

Conversation

bullet03
Copy link
Contributor

@bullet03 bullet03 commented Jul 14, 2022

Resolves #23004

  • update shortcodes languages from go to typescript

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@bullet03 bullet03 marked this pull request as ready for review July 14, 2022 18:42
@bullet03
Copy link
Contributor Author

bullet03 commented Jul 14, 2022

@robertwb, I found a couple of shortcodes with typescript had go naming in them. Curent PR can update these shortcodes. Is it fine?

before:

go_bug
go_2_bug
go_3_bug


after:

go_fix
go_2_fix
go_3_fix

@bullet03 bullet03 force-pushed the website-fix-shortcode-languages branch from 3e22de2 to ce80ee3 Compare September 2, 2022 08:00
@alevtinaboiko
Copy link

Verified, works as expected. Reviewed and tested by QA

@bullet03
Copy link
Contributor Author

bullet03 commented Sep 8, 2022

@pcoet, could you, please, review current PR?

@bullet03
Copy link
Contributor Author

bullet03 commented Sep 9, 2022

@aromanenko-dev, could you kindly help with merge? PR was approved.

@aromanenko-dev aromanenko-dev merged commit 733b056 into apache:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Double GO button in documentation/programming-guide
4 participants