Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Playground][Backend][Bug]: Moving the initialization of properties file #22310

Merged
merged 4 commits into from
Aug 8, 2022

Conversation

vchunikhin
Copy link
Contributor

@vchunikhin vchunikhin commented Jul 16, 2022

fixes #22309

@VladMatyunin

Since Sdk_SDK_UNSPECIFIED in charge of datastore interaction, the properties file is needed only for this sdk
Otherwise, will be the next error for other SDKs like that:

│panic: Config File "properties" Not Found in "[/]"
│
│goroutine 1 [running]:
│main.main()
│	/go/src/playground/backend/cmd/server/server.go:203 +0x33

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@@ -55,6 +55,7 @@ ENV SERVER_PORT=8080
ENV APP_WORK_DIR=/opt/playground/backend/
ENV BEAM_SDK="SDK_GO"
ENV BUCKET_NAME="playground-precompiled-objects"
ENV PROPERTY_PATH=/opt/playground/backend/properties.yaml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PROPERTY_PATH was added for every docker file to avoid problems when we will use properties.yaml for runners (JAVA, PYTHON, SCIO, GO)

@vchunikhin vchunikhin marked this pull request as ready for review July 21, 2022 07:00
@vchunikhin
Copy link
Contributor Author

R: @pabloem

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@pabloem
Copy link
Member

pabloem commented Aug 8, 2022

lgtm thanks!

@pabloem pabloem merged commit 95cbff1 into apache:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Playground][Bug]: Moving the initialization of properties file
2 participants