-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove normalization in Pytorch Image Segmentation example #22371
Conversation
Run Python 3.7 PostCommit |
Run Python 3.9 PostCommit |
remind me after tests pass |
Ok - I'll remind @yeandy after tests pass |
Codecov Report
@@ Coverage Diff @@
## master #22371 +/- ##
=======================================
Coverage 74.17% 74.17%
=======================================
Files 706 706
Lines 93229 93228 -1
=======================================
+ Hits 69152 69155 +3
+ Misses 22809 22805 -4
Partials 1268 1268
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
All checks have passed: @yeandy |
Assigning reviewers. If you would like to opt out of this review, comment R: @pabloem for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Reminder, please take a look at this pr: @pabloem |
R: @AnandInguva |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
e84addb
to
fb9ac0d
Compare
Run Python 3.7 PostCommit |
Run Python 3.9 PostCommit |
sdks/python/apache_beam/examples/inference/pytorch_image_segmentation.py
Outdated
Show resolved
Hide resolved
Run Python 3.7 PostCommit |
Run Python 3.9 PostCommit |
Failures are unrelate. Local gradle test passes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd like to get a green run on PostCommits before merging
One of the test(unrelated here) is fixed recently. Let's rerun the post commits again |
Run Python 3.7 PostCommit |
Run Python 3.9 PostCommit |
Run Python 3.7 PostCommit |
Run Python 3.9 PostCommit |
Tests pass @TheNeuralBit @tvalentyn |
Thanks @yeandy! |
Fixes #22224. I mistakenly added a normalization operation during the preprocessing step. This has been removed. The actuals file has also been overwritten with the updated outputs.
This should also fix the issue filed here #22413 because of a premature update of the actuals file.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.