Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove normalization in Pytorch Image Segmentation example #22371

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

yeandy
Copy link
Contributor

@yeandy yeandy commented Jul 20, 2022

Fixes #22224. I mistakenly added a normalization operation during the preprocessing step. This has been removed. The actuals file has also been overwritten with the updated outputs.

This should also fix the issue filed here #22413 because of a premature update of the actuals file.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@yeandy
Copy link
Contributor Author

yeandy commented Jul 20, 2022

Run Python 3.7 PostCommit

@yeandy
Copy link
Contributor Author

yeandy commented Jul 20, 2022

Run Python 3.9 PostCommit

@yeandy
Copy link
Contributor Author

yeandy commented Jul 20, 2022

remind me after tests pass

@github-actions
Copy link
Contributor

Ok - I'll remind @yeandy after tests pass

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #22371 (4417cad) into master (b0b9c68) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22371   +/-   ##
=======================================
  Coverage   74.17%   74.17%           
=======================================
  Files         706      706           
  Lines       93229    93228    -1     
=======================================
+ Hits        69152    69155    +3     
+ Misses      22809    22805    -4     
  Partials     1268     1268           
Flag Coverage Δ
python 83.54% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...m/examples/inference/pytorch_image_segmentation.py 0.00% <ø> (ø)
...hon/apache_beam/runners/worker/bundle_processor.py 93.30% <0.00%> (-0.25%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.09% <0.00%> (+0.15%) ⬆️
...hon/apache_beam/runners/direct/test_stream_impl.py 94.02% <0.00%> (+0.74%) ⬆️
sdks/python/apache_beam/io/source_test_utils.py 89.40% <0.00%> (+1.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@github-actions
Copy link
Contributor

All checks have passed: @yeandy

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @pabloem for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @pabloem

@yeandy
Copy link
Contributor Author

yeandy commented Jul 28, 2022

R: @AnandInguva

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@yeandy
Copy link
Contributor Author

yeandy commented Jul 28, 2022

Run Python 3.7 PostCommit

@yeandy
Copy link
Contributor Author

yeandy commented Jul 28, 2022

Run Python 3.9 PostCommit

@yeandy
Copy link
Contributor Author

yeandy commented Jul 28, 2022

Run Python 3.7 PostCommit

@yeandy
Copy link
Contributor Author

yeandy commented Jul 28, 2022

Run Python 3.9 PostCommit

@yeandy
Copy link
Contributor Author

yeandy commented Jul 29, 2022

Failures are unrelate. Local gradle test passes.

@yeandy
Copy link
Contributor Author

yeandy commented Jul 29, 2022

R: @TheNeuralBit

Copy link
Member

@TheNeuralBit TheNeuralBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like to get a green run on PostCommits before merging

@AnandInguva
Copy link
Contributor

AnandInguva commented Jul 29, 2022

One of the test(unrelated here) is fixed recently. Let's rerun the post commits again

@AnandInguva
Copy link
Contributor

Run Python 3.7 PostCommit

@AnandInguva
Copy link
Contributor

Run Python 3.9 PostCommit

@yeandy
Copy link
Contributor Author

yeandy commented Aug 1, 2022

Run Python 3.7 PostCommit

@yeandy
Copy link
Contributor Author

yeandy commented Aug 1, 2022

Run Python 3.9 PostCommit

@yeandy
Copy link
Contributor Author

yeandy commented Aug 2, 2022

Tests pass @TheNeuralBit @tvalentyn

@TheNeuralBit
Copy link
Member

Thanks @yeandy!

@TheNeuralBit TheNeuralBit merged commit 4f02372 into apache:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Remove normalize before RunInference in pytorch_image_segmentation.py
3 participants