Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website] update contribution content collapse #22468

Conversation

bullet03
Copy link
Contributor

@bullet03 bullet03 commented Jul 27, 2022

Content of Overview and Contribute Code sections was hiding on width between 640px and 768px. Contribute Code section didn't have a correct collalpse html structure.

  • fix Overview and Contribute Code sections, so content collapse works correctly on width 640px and lower
  • update related styles in _list.scss

before:
collapse_before

after:
collapse_after


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@bullet03 bullet03 force-pushed the website-update-contribution-content-collapse branch from 2b987e5 to 2e85825 Compare July 28, 2022 10:28
@bullet03 bullet03 force-pushed the website-update-contribution-content-collapse branch from 2e85825 to 05eb9b2 Compare July 28, 2022 11:15
@bullet03 bullet03 marked this pull request as ready for review July 29, 2022 11:27
@alevtinaboiko
Copy link

Verified, works as expected. Reviewed and tested by QA

@bullet03
Copy link
Contributor Author

bullet03 commented Aug 4, 2022

@pcoet, could you kindly review current PR?

Copy link
Collaborator

@pcoet pcoet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this!

@bullet03
Copy link
Contributor Author

bullet03 commented Aug 8, 2022

@aromanenko-dev, this PR was approved. Could you, please, help with merge?

@bullet03
Copy link
Contributor Author

bullet03 commented Aug 8, 2022

Thanks for finding and fixing this!

Was glad to help :-)

@aromanenko-dev
Copy link
Contributor

Sure! Please, don't forget to link it with a proper issue. Thanks

@aromanenko-dev aromanenko-dev merged commit e86456e into apache:master Aug 10, 2022
@bullet03
Copy link
Contributor Author

Sure! Please, don't forget to link it with a proper issue. Thanks

Got it. Thank you for reminding and for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants