Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website] Update ctas button container on homepage #22498

Merged

Conversation

bullet03
Copy link
Contributor

@bullet03 bullet03 commented Jul 28, 2022

Resolves #22521

  • change media-query max-width to ak-breakpoint-xl variable, so ctas button container have horizontal scroll to fit all buttons on screen when they overflow

before:
ctas_before

after:
ctas_after


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@bullet03 bullet03 changed the title [Website] [Website] Update ctas button container on homepage Jul 28, 2022
@bullet03 bullet03 force-pushed the website-update-homepage-ctas-buttons branch from 119e01c to 5fb173a Compare August 23, 2022 17:34
@bullet03 bullet03 force-pushed the website-update-homepage-ctas-buttons branch from 5fb173a to 3cf69db Compare August 24, 2022 08:03
@alevtinaboiko
Copy link

Verified, works as expected. Reviewed and tested by QA

@bullet03 bullet03 marked this pull request as ready for review August 25, 2022 08:43
@bullet03
Copy link
Contributor Author

@pcoet, could you, please, review current PR?

@bullet03
Copy link
Contributor Author

@pabloem, could you, please, help with merge?

@bullet03
Copy link
Contributor Author

bullet03 commented Sep 9, 2022

@aromanenko-dev, could you kindly help with merge? PR was approved.

@pabloem pabloem merged commit 88036d9 into apache:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Home page. The edge buttons cut off at page size 1275.20px x 693.6px, no scrolling
4 participants