-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change _build import from setuptools to distutils #22503
Conversation
Run Python 3.8 PostCommit |
Run Python 3.9 PostCommit |
Codecov Report
@@ Coverage Diff @@
## master #22503 +/- ##
==========================================
- Coverage 74.17% 74.14% -0.04%
==========================================
Files 706 706
Lines 93229 93275 +46
==========================================
+ Hits 69152 69155 +3
- Misses 22809 22852 +43
Partials 1268 1268
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Assigning reviewers. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
R: @apilloud |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Successful postcommit runs that fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(I don't actually know what I'm looking at here, I haven't worked on python for years.)
Run Python PreCommit |
@AnandInguva Could you create a cherry-pick PR for the new release-2.41.0 branch? Thanks! |
Postcommit & Lint passed: https://ci-beam.apache.org/job/beam_PostCommit_Python39_PR/39/ , other suites not affected, merging. |
See issue: #22516
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.