Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change _build import from setuptools to distutils #22503

Merged
merged 3 commits into from
Jul 29, 2022

Conversation

AnandInguva
Copy link
Contributor

@AnandInguva AnandInguva commented Jul 28, 2022

See issue: #22516


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@AnandInguva
Copy link
Contributor Author

Run Python 3.8 PostCommit

@AnandInguva
Copy link
Contributor Author

Run Python 3.9 PostCommit

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #22503 (6e465a9) into master (b0b9c68) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 6e465a9 differs from pull request most recent head 58c1bd0. Consider uploading reports for the commit 58c1bd0 to get more accurate results

@@            Coverage Diff             @@
##           master   #22503      +/-   ##
==========================================
- Coverage   74.17%   74.14%   -0.04%     
==========================================
  Files         706      706              
  Lines       93229    93275      +46     
==========================================
+ Hits        69152    69155       +3     
- Misses      22809    22852      +43     
  Partials     1268     1268              
Flag Coverage Δ
python 83.48% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...on/apache_beam/examples/complete/juliaset/setup.py 0.00% <0.00%> (ø)
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 90.06% <0.00%> (-1.33%) ⬇️
sdks/python/apache_beam/examples/sql_taxi.py 0.00% <0.00%> (ø)
...python/apache_beam/examples/wordcount_xlang_sql.py 0.00% <0.00%> (ø)
...ython/apache_beam/examples/kafkataxi/kafka_taxi.py 0.00% <0.00%> (ø)
...hon/apache_beam/runners/worker/bundle_processor.py 93.67% <0.00%> (+0.12%) ⬆️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.09% <0.00%> (+0.15%) ⬆️
...eam/runners/interactive/interactive_environment.py 92.02% <0.00%> (+0.30%) ⬆️
sdks/python/apache_beam/runners/direct/executor.py 97.01% <0.00%> (+0.54%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@AnandInguva
Copy link
Contributor Author

R: @apilloud

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@AnandInguva
Copy link
Contributor Author

AnandInguva commented Jul 28, 2022

@AnandInguva AnandInguva changed the title Change build from setuptools to distutils Change _build import from setuptools to distutils Jul 28, 2022
Copy link
Member

@apilloud apilloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(I don't actually know what I'm looking at here, I haven't worked on python for years.)

@AnandInguva
Copy link
Contributor Author

Run Python PreCommit

@kileys
Copy link
Contributor

kileys commented Jul 29, 2022

@AnandInguva Could you create a cherry-pick PR for the new release-2.41.0 branch? Thanks!

@tvalentyn
Copy link
Contributor

Postcommit & Lint passed: https://ci-beam.apache.org/job/beam_PostCommit_Python39_PR/39/ , other suites not affected, merging.

@tvalentyn tvalentyn merged commit 815b0d3 into apache:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants