Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax the google-api-core dependency. #22513

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Conversation

tvalentyn
Copy link
Contributor

Relax the google-api-core dependency with an understanding that the incompatibility will be addressed in 2.8.3 or following next version (cc: @parthea)

This will reduce the diamond dependency risks in apache-beam in the future, when other libraries require newer versions of google-api-core.

We will also work on sunsetting the python spanner io in favor of the cross-language implementation: #22480. We will try to complete this before EOY (cc: @johnjcasey);

R: @kileys

cc: @BjornPrime


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #22513 (44902a1) into master (f4f1de3) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22513   +/-   ##
=======================================
  Coverage   74.17%   74.17%           
=======================================
  Files         706      706           
  Lines       93226    93229    +3     
=======================================
+ Hits        69148    69152    +4     
+ Misses      22810    22809    -1     
  Partials     1268     1268           
Flag Coverage Δ
python 83.54% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/transforms/combiners.py 93.05% <0.00%> (-0.39%) ⬇️
...beam/testing/load_tests/load_test_metrics_utils.py 34.07% <0.00%> (-0.39%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.42% <0.00%> (-0.13%) ⬇️
setup.py 0.00% <0.00%> (ø)
...s/python/apache_beam/runners/portability/stager.py 85.54% <0.00%> (ø)
...on/apache_beam/examples/complete/juliaset/setup.py 0.00% <0.00%> (ø)
...ks/python/apache_beam/runners/worker/sdk_worker.py 88.94% <0.00%> (+0.31%) ⬆️
sdks/python/apache_beam/runners/direct/executor.py 97.01% <0.00%> (+0.54%) ⬆️
...python/apache_beam/runners/worker/worker_status.py 79.71% <0.00%> (+2.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@tvalentyn tvalentyn merged commit 48b5349 into apache:master Jul 28, 2022
@tvalentyn tvalentyn deleted the spannerio branch July 28, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants