Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude grpcio==1.48.0 #22539

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Exclude grpcio==1.48.0 #22539

merged 1 commit into from
Aug 1, 2022

Conversation

tvalentyn
Copy link
Contributor

Exclude the broken version grpcio==1.48.0
Fixes #22533

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

Exclude the broken version grpcio==1.48.0
@tvalentyn
Copy link
Contributor Author

R: @chamikaramj

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Jul 30, 2022

Codecov Report

Merging #22539 (10e092e) into master (e5e3cb2) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22539   +/-   ##
=======================================
  Coverage   74.17%   74.17%           
=======================================
  Files         706      706           
  Lines       93229    93229           
=======================================
+ Hits        69148    69154    +6     
+ Misses      22813    22807    -6     
  Partials     1268     1268           
Flag Coverage Δ
python 83.54% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 90.06% <0.00%> (-1.33%) ⬇️
sdks/python/apache_beam/internal/metrics/metric.py 93.00% <0.00%> (-1.00%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 92.44% <0.00%> (-0.65%) ⬇️
sdks/python/apache_beam/runners/common.py 88.59% <0.00%> (-0.13%) ⬇️
...on/apache_beam/examples/complete/juliaset/setup.py 0.00% <0.00%> (ø)
sdks/python/apache_beam/transforms/util.py 96.22% <0.00%> (+0.15%) ⬆️
...eam/runners/interactive/interactive_environment.py 92.02% <0.00%> (+0.30%) ⬆️
...hon/apache_beam/runners/worker/bundle_processor.py 93.54% <0.00%> (+0.37%) ⬆️
sdks/python/apache_beam/transforms/combiners.py 93.43% <0.00%> (+0.38%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@chamikaramj
Copy link
Contributor

LGTM. Thanks.

@tvalentyn tvalentyn merged commit 6f416f8 into master Aug 1, 2022
@tvalentyn tvalentyn deleted the tvalentyn-patch-1 branch September 1, 2022 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: grpcio==1.48.0 causes Java expansion service to hang on startup in Python XLang pipelines.
2 participants