-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added experimental annotation to fixes #22564 #22565
Added experimental annotation to fixes #22564 #22565
Conversation
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #22565 +/- ##
==========================================
+ Coverage 74.18% 74.22% +0.04%
==========================================
Files 706 707 +1
Lines 93229 93299 +70
==========================================
+ Hits 69159 69253 +94
+ Misses 22802 22778 -24
Partials 1268 1268
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remind me the behavior of this tag?
Do we need to remove this note from the docstring?
**NOTE:** This API and its implementation are under development and
do not provide backward compatibility guarantees.
@yeandy |
@tvalentyn I just tested out doc generation. Good thing because there was an odd doc generation behavior. To get around it, I had to set all, which I think is something we should do anyhow. The experimental annotation doesn't do anything with doc generation at this point, I don't think we need to add todo's or anything, because when/if someone does make a change, they will need to make modifications themselves at that piont. |
I am not sure what you are referring to. |
Run Python PreCommit |
Could you please check the failing test and file an issues if there is none filed at s.apache.org/beam-flakes ? Thanks. |
Adds experimental annotation to SklearnModelHandlerPandas and PytorchModelHandlerKeyedTensor.
New PTransforms that are experimental should be marked with an experimental annotation.
https://beam.apache.org/contribute/ptransform-style-guide/#compatibility
Though these are not PTransforms the annotation can generate warnings in logs.
fixes #22564
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.