Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE][BEAM-14118, #21639] Test gRPC 1.48.1 #22595

Closed
wants to merge 3 commits into from

Conversation

lukecwik
Copy link
Member

@lukecwik lukecwik commented Aug 4, 2022

Linkage checker failures under 1.48.1:

Class org.eclipse.jetty.npn.NextProtoNego is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.ssl.JettyNpnSslEngine (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.eclipse.jetty.alpn.ALPN$ClientProvider is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.ssl.JettyAlpnSslEngine (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.eclipse.jetty.alpn.ALPN is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.ssl.JettyAlpnSslEngine (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.bouncycastle.asn1.x500.X500Name is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.ssl.util.BouncyCastleSelfSignedCertGenerator (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.bouncycastle.cert.jcajce.JcaX509v3CertificateBuilder is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.ssl.util.BouncyCastleSelfSignedCertGenerator (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.bouncycastle.operator.jcajce.JcaContentSignerBuilder is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.ssl.util.BouncyCastleSelfSignedCertGenerator (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.bouncycastle.cert.X509v3CertificateBuilder is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.ssl.util.BouncyCastleSelfSignedCertGenerator (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.bouncycastle.cert.jcajce.JcaX509CertificateConverter is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.ssl.util.BouncyCastleSelfSignedCertGenerator (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.bouncycastle.jce.provider.BouncyCastleProvider is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.ssl.util.BouncyCastleSelfSignedCertGenerator (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.eclipse.jetty.npn.NextProtoNego$ClientProvider is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.ssl.JettyNpnSslEngine (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.eclipse.jetty.npn.NextProtoNego$ServerProvider is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.ssl.JettyNpnSslEngine (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.eclipse.jetty.alpn.ALPN$ServerProvider is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.ssl.JettyAlpnSslEngine (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class com.jcraft.jzlib.JZlib$WrapperType is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.ZlibUtil (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class com.jcraft.jzlib.JZlib is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.ZlibUtil (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class com.jcraft.jzlib.Inflater is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.ZlibUtil (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class com.jcraft.jzlib.Deflater is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.ZlibUtil (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class com.aayushatharva.brotli4j.decoder.DecoderJNI$Status is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.BrotliDecoder (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class com.github.luben.zstd.Zstd is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.ZstdEncoder (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class com.aayushatharva.brotli4j.encoder.Encoder$Parameters is not found;
  referenced by 3 class files
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.StandardCompressionOptions (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.BrotliOptions (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.BrotliEncoder (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class com.aayushatharva.brotli4j.decoder.DecoderJNI$Wrapper is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.BrotliDecoder (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class com.aayushatharva.brotli4j.encoder.Encoder$Mode is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.BrotliOptions (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.JZlibEncoder is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.ZlibCodecFactory (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.JZlibDecoder is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.ZlibCodecFactory (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class com.aayushatharva.brotli4j.encoder.Encoders is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.handler.codec.compression.BrotliEncoder (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.slf4j.Logger is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.util.internal.logging.Slf4JLogger (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.slf4j.LoggerFactory is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.util.internal.logging.Slf4JLoggerFactory (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.slf4j.helpers.NOPLoggerFactory is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.util.internal.logging.Slf4JLoggerFactory (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.slf4j.spi.LocationAwareLogger is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.util.internal.logging.Slf4JLoggerFactory (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.apache.beam.vendor.grpc.v1p48p1.io.netty.util.internal.logging.LocationAwareSlf4JLogger is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.util.internal.logging.Slf4JLoggerFactory (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class reactor.blockhound.integration.BlockHoundIntegration is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.util.internal.Hidden (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown
Class reactor.blockhound.BlockHound$Builder is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p48p1.io.netty.util.internal.Hidden (org.apache.beam:beam-vendor-grpc-1_48_1:0.1-SNAPSHOT)
  Cause:
    Unknown

Linkage checker failures under 1.43.2:

Class org.eclipse.jetty.npn.NextProtoNego$ServerProvider is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.ssl.JettyNpnSslEngine (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.bouncycastle.asn1.x500.X500Name is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.ssl.util.BouncyCastleSelfSignedCertGenerator (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.bouncycastle.cert.jcajce.JcaX509v3CertificateBuilder is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.ssl.util.BouncyCastleSelfSignedCertGenerator (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.bouncycastle.operator.jcajce.JcaContentSignerBuilder is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.ssl.util.BouncyCastleSelfSignedCertGenerator (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.bouncycastle.cert.X509v3CertificateBuilder is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.ssl.util.BouncyCastleSelfSignedCertGenerator (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.bouncycastle.cert.jcajce.JcaX509CertificateConverter is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.ssl.util.BouncyCastleSelfSignedCertGenerator (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.bouncycastle.jce.provider.BouncyCastleProvider is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.ssl.util.BouncyCastleSelfSignedCertGenerator (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.eclipse.jetty.alpn.ALPN is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.ssl.JettyAlpnSslEngine (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.eclipse.jetty.npn.NextProtoNego is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.ssl.JettyNpnSslEngine (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.eclipse.jetty.alpn.ALPN$ClientProvider is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.ssl.JettyAlpnSslEngine (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.eclipse.jetty.alpn.ALPN$ServerProvider is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.ssl.JettyAlpnSslEngine (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.codec.compression.JZlibEncoder is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.codec.compression.ZlibCodecFactory (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.codec.compression.JZlibDecoder is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.codec.compression.ZlibCodecFactory (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
  Cause:
    Unknown
Class com.jcraft.jzlib.JZlib$WrapperType is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.codec.compression.ZlibUtil (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
  Cause:
    Unknown
Class com.jcraft.jzlib.JZlib is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.codec.compression.ZlibUtil (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
  Cause:
    Unknown
Class com.jcraft.jzlib.Inflater is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.codec.compression.ZlibUtil (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
  Cause:
    Unknown
Class com.jcraft.jzlib.Deflater is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p43p2.io.netty.handler.codec.compression.ZlibUtil (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
  Cause:
    Unknown
Class reactor.blockhound.integration.BlockHoundIntegration is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p43p2.io.netty.util.internal.Hidden (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
  Cause:
    Unknown
Class reactor.blockhound.BlockHound$Builder is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p43p2.io.netty.util.internal.Hidden (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.slf4j.Logger is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p43p2.io.netty.util.internal.logging.Slf4JLogger (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.slf4j.LoggerFactory is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p43p2.io.netty.util.internal.logging.Slf4JLoggerFactory (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.slf4j.helpers.NOPLoggerFactory is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p43p2.io.netty.util.internal.logging.Slf4JLoggerFactory (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.slf4j.spi.LocationAwareLogger is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p43p2.io.netty.util.internal.logging.Slf4JLoggerFactory (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
  Cause:
    Unknown
Class org.apache.beam.vendor.grpc.v1p43p2.io.netty.util.internal.logging.LocationAwareSlf4JLogger is not found;
  referenced by 1 class file
    org.apache.beam.vendor.grpc.v1p43p2.io.netty.util.internal.logging.Slf4JLoggerFactory (org.apache.beam:beam-vendor-grpc-1_43_2:0.1-SNAPSHOT)
  Cause:
    Unknown

The differences are in optional new compression algorithms zstd and brotli and NextProtoNego$ClientProvider which are safe to exclude.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #22595 (94e4a79) into master (c8d92b0) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22595   +/-   ##
=======================================
  Coverage   74.22%   74.23%           
=======================================
  Files         707      707           
  Lines       93301    93301           
=======================================
+ Hits        69251    69260    +9     
+ Misses      22782    22773    -9     
  Partials     1268     1268           
Flag Coverage Δ
python 83.61% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/io/source_test_utils.py 88.01% <0.00%> (-1.39%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.09% <0.00%> (+0.15%) ⬆️
...hon/apache_beam/runners/worker/bundle_processor.py 93.67% <0.00%> (+0.24%) ⬆️
...eam/runners/portability/fn_api_runner/execution.py 93.08% <0.00%> (+0.64%) ⬆️
...hon/apache_beam/runners/direct/test_stream_impl.py 94.02% <0.00%> (+0.74%) ⬆️
...che_beam/runners/interactive/interactive_runner.py 91.39% <0.00%> (+1.32%) ⬆️
.../python/apache_beam/testing/test_stream_service.py 92.85% <0.00%> (+4.76%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @Abacn for label build.
R: @pabloem for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@lukecwik
Copy link
Member Author

lukecwik commented Aug 5, 2022

Tests passed, closing PR and will split into relevant parts.

@lukecwik lukecwik closed this Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant