Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go SDK]: Implement standalone single-precision float encoder #22664

Merged
merged 5 commits into from
Aug 12, 2022

Conversation

jrmccluskey
Copy link
Contributor

Implements a specific single-precision float coder to match Java and Python coder implementations, replacing old routing that treated float32 values as float64 for encoding/decoding purposes.

Fixes #22629


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the go label Aug 10, 2022
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #22664 (b51dacb) into master (8fb4945) will increase coverage by 0.00%.
The diff coverage is 76.92%.

@@           Coverage Diff           @@
##           master   #22664   +/-   ##
=======================================
  Coverage   74.19%   74.19%           
=======================================
  Files         708      709    +1     
  Lines       93465    93489   +24     
=======================================
+ Hits        69347    69365   +18     
- Misses      22843    22847    +4     
- Partials     1275     1277    +2     
Flag Coverage Δ
go 51.54% <76.92%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/core/graph/coder/row_decoder.go 63.82% <70.00%> (+0.09%) ⬆️
sdks/go/pkg/beam/core/graph/coder/float.go 72.72% <72.72%> (ø)
sdks/go/pkg/beam/core/graph/coder/row_encoder.go 68.06% <100.00%> (+0.54%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jrmccluskey
Copy link
Contributor Author

R: @lostluck @TheNeuralBit

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I recommend also adding a mention of this to Changes.md, in particular in the breaking changes section, as most coder changes are "breaking", and that this is user observable behavior in the coding.

@jrmccluskey jrmccluskey merged commit 7a9bb76 into apache:master Aug 12, 2022
MarcoRob pushed a commit to MarcoRob/beam that referenced this pull request Sep 5, 2022
…#22664)

* Implement standalone single-precision float encoder

* Add fuzz test

* Fix buffer size

* Fix docstring

* Add CHANGES.md entry
@jrmccluskey jrmccluskey deleted the singleCoder branch July 11, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Mismatch in single-precision float encoding between Java and Go RowCoder implementations
2 participants