Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-1655] Maintain Safe-to-ACK IDs through Coder in PubsubIO #2268

Closed
wants to merge 1 commit into from

Conversation

tgroh
Copy link
Member

@tgroh tgroh commented Mar 17, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

ACK them after NACKing all messages that have not been read.

Remove checkStates around finalizeCheckpoint that are not consistent
with the finalizeCheckpoint requirements.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 69.64% when pulling d12b19a on tgroh:pubsub_io_checkpoints into b672cde on apache:master.

@asfbot
Copy link

asfbot commented Mar 17, 2017

ACK them after NACKing all messages that have not been read.

Remove checkStates around finalizeCheckpoint that are not consistent
with the finalizeCheckpoint requirements.
@asfbot
Copy link

asfbot commented Mar 20, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8583/

Build result: FAILURE

[...truncated 667.86 KB...] at org.apache.maven.wagon.providers.http.httpclient.impl.DefaultBHttpClientConnection.receiveResponseHeader(DefaultBHttpClientConnection.java:161) at org.apache.maven.wagon.providers.http.httpclient.impl.conn.CPoolProxy.receiveResponseHeader(CPoolProxy.java:153) at org.apache.maven.wagon.providers.http.httpclient.protocol.HttpRequestExecutor.doReceiveResponse(HttpRequestExecutor.java:271) at org.apache.maven.wagon.providers.http.httpclient.protocol.HttpRequestExecutor.execute(HttpRequestExecutor.java:123) at org.apache.maven.wagon.providers.http.httpclient.impl.execchain.MainClientExec.execute(MainClientExec.java:254) at org.apache.maven.wagon.providers.http.httpclient.impl.execchain.ProtocolExec.execute(ProtocolExec.java:195) at org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec.execute(RetryExec.java:86) at org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RedirectExec.execute(RedirectExec.java:108) at org.apache.maven.wagon.providers.http.httpclient.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:184) at org.apache.maven.wagon.providers.http.httpclient.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:82) at org.apache.maven.wagon.providers.http.AbstractHttpClientWagon.execute(AbstractHttpClientWagon.java:832) at org.apache.maven.wagon.providers.http.AbstractHttpClientWagon.fillInputData(AbstractHttpClientWagon.java:983) ... 61 more2017-03-20T17:16:27.113 [ERROR] 2017-03-20T17:16:27.114 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-03-20T17:16:27.114 [ERROR] 2017-03-20T17:16:27.114 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-03-20T17:16:27.114 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException2017-03-20T17:16:27.114 [ERROR] 2017-03-20T17:16:27.114 [ERROR] After correcting the problems, you can resume the build with the command2017-03-20T17:16:27.114 [ERROR] mvn -rf :beam-sdks-java-io-elasticsearchchannel stoppedSetting status of 158380b to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8583/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

@tgroh
Copy link
Member Author

tgroh commented Mar 20, 2017

retest this please

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 70.138% when pulling 158380b on tgroh:pubsub_io_checkpoints into 6fa1fca on apache:master.

@asfbot
Copy link

asfbot commented Mar 20, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8584/
--none--

@tgroh tgroh closed this Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants