[Playground] [Backend] Datastore queries and mappers to get precompiled objects #22868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # playground/backend/cmd/server/server.go # playground/backend/internal/db/datastore/datastore_db.go # playground/backend/internal/db/datastore/datastore_db_test.go
# Conflicts: # playground/backend/cmd/server/controller_test.go # playground/backend/internal/db/mapper/datastore_mapper.go # playground/backend/internal/db/mapper/datastore_mapper_test.go
# Conflicts: # playground/backend/internal/db/datastore/datastore_db.go
|
R: @pabloem |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
# Conflicts: # playground/infrastructure/cd_helper.py # playground/infrastructure/config.py # playground/infrastructure/datastore_client.py # playground/infrastructure/helper.py # playground/infrastructure/requirements.txt # playground/infrastructure/test_datastore_client.py # playground/infrastructure/test_helper.py
|
lgtm thanks |
dedocibula
pushed a commit
to dedocibula/beam
that referenced
this pull request
Sep 15, 2022
…ed objects (apache#22868) * [Playground] [Backend] added the datastore query to get an example catalog * [Playground] [Backend] added datastore queries to get precompiled objects * [Playground] [Backend] refactoring for datastore db * [Playground] [Backend] updated complexity field * [Playground] [Backend] updated complexity field * [Playground] [Backend] fixed integration tests for datastore * [Playground] [Backend] fixed integration tests for datastore * [Playground] [Backend] added testing data cleaner * [Playground] [Backend] added testing data cleaner * [Playground] [Backend] refactoring for integration tests * [Playground] [Backend] edited getting datastore key * [Playground] [Backend] edited getting datastore key * [Playground] [Backend] updated unit tests for diferent namespaces * [Playground] [Infrastructure] added the datastore client * [Playground] [Infrastructure] added the type property to an example entity * [Playground] [Infrastructure] removed the cloud storage client * [Playground] [Infrastructure] changed validation examples for duplicates by name * [Playground] [Infrastructure] fixed duplicated example names * [Playground] [Infrastructure] added the google cloud project id as an env variable * [Playground] [Backend] updated docker files for runners * [Playground] [Backend] added SDK validation to save a code snippet * [Playground] [Backend] removed comments * [Playground] [Backend] resolved comments after review * [Playground] [Infrastructure] updated dependency versions * [Playground] [Backend] fixed the java runner for examples with graphs * [Playground] [Infrastructure] added loading catalogs to the cloud datastore * [Playground] [Backend] remove extra imports after merging * [Playground] [Backend] fixes after merging with other branches * [Playground] [Backend] added genreics for one method * fixing incorrect merge Co-authored-by: oborysevych <oleg.borisevich@akvelon.com>
kkdoon
pushed a commit
to twitter-forks/beam
that referenced
this pull request
Sep 29, 2022
…ed objects (apache#22868) * [Playground] [Backend] added the datastore query to get an example catalog * [Playground] [Backend] added datastore queries to get precompiled objects * [Playground] [Backend] refactoring for datastore db * [Playground] [Backend] updated complexity field * [Playground] [Backend] updated complexity field * [Playground] [Backend] fixed integration tests for datastore * [Playground] [Backend] fixed integration tests for datastore * [Playground] [Backend] added testing data cleaner * [Playground] [Backend] added testing data cleaner * [Playground] [Backend] refactoring for integration tests * [Playground] [Backend] edited getting datastore key * [Playground] [Backend] edited getting datastore key * [Playground] [Backend] updated unit tests for diferent namespaces * [Playground] [Infrastructure] added the datastore client * [Playground] [Infrastructure] added the type property to an example entity * [Playground] [Infrastructure] removed the cloud storage client * [Playground] [Infrastructure] changed validation examples for duplicates by name * [Playground] [Infrastructure] fixed duplicated example names * [Playground] [Infrastructure] added the google cloud project id as an env variable * [Playground] [Backend] updated docker files for runners * [Playground] [Backend] added SDK validation to save a code snippet * [Playground] [Backend] removed comments * [Playground] [Backend] resolved comments after review * [Playground] [Infrastructure] updated dependency versions * [Playground] [Backend] fixed the java runner for examples with graphs * [Playground] [Infrastructure] added loading catalogs to the cloud datastore * [Playground] [Backend] remove extra imports after merging * [Playground] [Backend] fixes after merging with other branches * [Playground] [Backend] added genreics for one method * fixing incorrect merge Co-authored-by: oborysevych <oleg.borisevich@akvelon.com>
cushon
pushed a commit
to cushon/beam
that referenced
this pull request
Oct 17, 2022
…ed objects (apache#22868) * [Playground] [Backend] added the datastore query to get an example catalog * [Playground] [Backend] added datastore queries to get precompiled objects * [Playground] [Backend] refactoring for datastore db * [Playground] [Backend] updated complexity field * [Playground] [Backend] updated complexity field * [Playground] [Backend] fixed integration tests for datastore * [Playground] [Backend] fixed integration tests for datastore * [Playground] [Backend] added testing data cleaner * [Playground] [Backend] added testing data cleaner * [Playground] [Backend] refactoring for integration tests * [Playground] [Backend] edited getting datastore key * [Playground] [Backend] edited getting datastore key * [Playground] [Backend] updated unit tests for diferent namespaces * [Playground] [Infrastructure] added the datastore client * [Playground] [Infrastructure] added the type property to an example entity * [Playground] [Infrastructure] removed the cloud storage client * [Playground] [Infrastructure] changed validation examples for duplicates by name * [Playground] [Infrastructure] fixed duplicated example names * [Playground] [Infrastructure] added the google cloud project id as an env variable * [Playground] [Backend] updated docker files for runners * [Playground] [Backend] added SDK validation to save a code snippet * [Playground] [Backend] removed comments * [Playground] [Backend] resolved comments after review * [Playground] [Infrastructure] updated dependency versions * [Playground] [Backend] fixed the java runner for examples with graphs * [Playground] [Infrastructure] added loading catalogs to the cloud datastore * [Playground] [Backend] remove extra imports after merging * [Playground] [Backend] fixes after merging with other branches * [Playground] [Backend] added genreics for one method * fixing incorrect merge Co-authored-by: oborysevych <oleg.borisevich@akvelon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@olehborysevych
fixes #22874
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.