Improvements to SchemaTransform implementations for BQ and Kafka #23045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Java_Kafka_IO_Direct PreCommit |
|
Run Python_PVR_Flink PreCommit |
|
Run Java_Examples_Dataflow PreCommit |
pabloem
force-pushed
the
scht-improvements
branch
from
b7625f7
to
e3918ca
Compare
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @apilloud for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Run Java PreCommit |
|
Run Java PreCommit |
|
Run Java_GCP_IO_Direct PreCommit |
|
Run Spotless PreCommit |
|
Run Java_GCP_IO_Direct PreCommit |
dedocibula
pushed a commit
to dedocibula/beam
that referenced
this pull request
Sep 15, 2022
…che#23045) * Improvements to SchemaTransform implementations for BQ and Kafka * Fix kafka null checs * fixup * fixup? * few improvements * fixup * adding test * fix issue with hashcode
kkdoon
pushed a commit
to twitter-forks/beam
that referenced
this pull request
Sep 29, 2022
…che#23045) * Improvements to SchemaTransform implementations for BQ and Kafka * Fix kafka null checs * fixup * fixup? * few improvements * fixup * adding test * fix issue with hashcode
cushon
pushed a commit
to cushon/beam
that referenced
this pull request
Oct 17, 2022
…che#23045) * Improvements to SchemaTransform implementations for BQ and Kafka * Fix kafka null checs * fixup * fixup? * few improvements * fixup * adding test * fix issue with hashcode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am removing several configuration options for Kafka Write SchemaTransform Configuration to simplify its usage (though we'll probably still need consumer configuration maps for authentication and so on).
For BQ I'm just adding a couple required lines.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.