-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin the version of cloudpickle to 2.1.x #23120
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23120 +/- ##
==========================================
- Coverage 73.71% 73.62% -0.09%
==========================================
Files 714 716 +2
Lines 95240 95299 +59
==========================================
- Hits 70203 70164 -39
- Misses 23740 23838 +98
Partials 1297 1297
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm more worried that a tight cloudpickle dependency will cause more conflicts with other libraries than dill.
I suppose we can roll this back if it causes too many problems, or better yet, vendor all our pickle libraries.
Tighten the bound of cloudpickle, since cloudpickle will now be used as default in Python-on-Java xlang scenario for reasons outlined in #23119
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.