Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-1809] Make TravisCI builds less broken #2326

Closed
wants to merge 2 commits into from

Conversation

wtanaka
Copy link
Contributor

@wtanaka wtanaka commented Mar 25, 2017

Before:

before

After:

screenshot from 2017-03-24 22-10-02

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 70.109% when pulling d713f85 on wtanaka:checkstyle into e5f1a64 on apache:master.

@asfbot
Copy link

asfbot commented Mar 25, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8796/
--none--

@wtanaka
Copy link
Contributor Author

wtanaka commented Mar 25, 2017

R: @dhalperi @tgroh @bjchambers or anyone else, is an "@" mention the best way to ask for a review on a pull request?

@wtanaka wtanaka changed the title Make TravisCI builds less broken [BEAM-1809] Make TravisCI builds less broken Mar 25, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 70.187% when pulling b339a1b on wtanaka:checkstyle into 3473055 on apache:master.

@asfbot
Copy link

asfbot commented Mar 25, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8806/
--none--

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 70.183% when pulling 4b3335e on wtanaka:checkstyle into c9e55a4 on apache:master.

@asfbot
Copy link

asfbot commented Mar 26, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8812/
--none--

…:check

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (default) on
project beam-sdks-parent: Failed during checkstyle execution: Unable to find
suppressions file at location: beam/suppressions.xml: Could not find resource
'beam/suppressions.xml'. -> [Help 1]
…:check

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (default) on
project beam-sdks-parent: Failed during checkstyle execution: Unable to find
suppressions file at location: beam/suppressions.xml: Could not find resource
'beam/suppressions.xml'. -> [Help 1]
@wtanaka
Copy link
Contributor Author

wtanaka commented Mar 27, 2017

R: @amitsela @aviemzur (is this how I ask for a review?)

@coveralls
Copy link

coveralls commented Mar 27, 2017

Coverage Status

Coverage decreased (-31.6%) to 38.61% when pulling f4e6225 on wtanaka:checkstyle into 026aec8 on apache:master.

@asfbot
Copy link

asfbot commented Mar 27, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8819/
--none--

@aviemzur
Copy link
Member

I believe @davorbonaci and @jasonkuster are working on the Travis issues.

@@ -1023,8 +1023,8 @@
</dependency>
</dependencies>
<configuration>
<configLocation>beam/checkstyle.xml</configLocation>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why this would be needed? This works fine in Jenkins and on my Desktop.

Java is supposed to pick up these files from the build-tools module on the classpath.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wtanaka, could this be a versioning issue, i.e., Travis uses an older version of something so we don't see this problem elsewhere?

@dhalperi
Copy link
Contributor

I think that @davorbonaci should probably handle this review.

@wtanaka
Copy link
Contributor Author

wtanaka commented Mar 28, 2017

sounds like this is going to be problematic, closing.

@wtanaka wtanaka closed this Mar 28, 2017
@wtanaka wtanaka deleted the checkstyle branch April 14, 2017 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants