-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-1809] Make TravisCI builds less broken #2326
Conversation
Refer to this link for build results (access rights to CI server needed): |
R: @dhalperi @tgroh @bjchambers or anyone else, is an "@" mention the best way to ask for a review on a pull request? |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
…:check [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (default) on project beam-sdks-parent: Failed during checkstyle execution: Unable to find suppressions file at location: beam/suppressions.xml: Could not find resource 'beam/suppressions.xml'. -> [Help 1]
…:check [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (default) on project beam-sdks-parent: Failed during checkstyle execution: Unable to find suppressions file at location: beam/suppressions.xml: Could not find resource 'beam/suppressions.xml'. -> [Help 1]
Refer to this link for build results (access rights to CI server needed): |
I believe @davorbonaci and @jasonkuster are working on the Travis issues. |
@@ -1023,8 +1023,8 @@ | |||
</dependency> | |||
</dependencies> | |||
<configuration> | |||
<configLocation>beam/checkstyle.xml</configLocation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know why this would be needed? This works fine in Jenkins and on my Desktop.
Java is supposed to pick up these files from the build-tools
module on the classpath.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wtanaka, could this be a versioning issue, i.e., Travis uses an older version of something so we don't see this problem elsewhere?
I think that @davorbonaci should probably handle this review. |
sounds like this is going to be problematic, closing. |
Before:
After: