Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-1713] Extracted anonymous classes to prevent things from being captured #2356

Conversation

staslev
Copy link
Contributor

@staslev staslev commented Mar 29, 2017

…identally.

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@staslev staslev force-pushed the BEAM-1713-SparkRuntimeContext-captured-in-StateSpecFunctions branch from 293fc59 to e2967d9 Compare March 29, 2017 12:19
@staslev staslev force-pushed the BEAM-1713-SparkRuntimeContext-captured-in-StateSpecFunctions branch from e2967d9 to 7d7a0a8 Compare March 29, 2017 12:29
@staslev
Copy link
Contributor Author

staslev commented Mar 29, 2017

R: @amitsela

@staslev
Copy link
Contributor Author

staslev commented Mar 29, 2017

Run Spark ValidatesRunner

@staslev staslev changed the title Extracted anonymous classes to prevent things from being captured inc… [BEAM-1713] Extracted anonymous classes to prevent things from being captured Mar 29, 2017
@amitsela
Copy link
Member

LGTM

@asfbot
Copy link

asfbot commented Mar 29, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8885/

Build result: FAILURE

[...truncated 1.21 MB...] at hudson.remoting.UserRequest.perform(UserRequest.java:153) at hudson.remoting.UserRequest.perform(UserRequest.java:50) at hudson.remoting.Request$2.run(Request.java:336) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745)Caused by: org.apache.maven.plugin.MojoFailureException: You have 2 Checkstyle violations. at org.apache.maven.plugin.checkstyle.CheckstyleViolationCheckMojo.execute(CheckstyleViolationCheckMojo.java:588) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) ... 31 more2017-03-29T12:41:16.696 [ERROR] 2017-03-29T12:41:16.696 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-03-29T12:41:16.696 [ERROR] 2017-03-29T12:41:16.696 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-03-29T12:41:16.696 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException2017-03-29T12:41:16.696 [ERROR] 2017-03-29T12:41:16.696 [ERROR] After correcting the problems, you can resume the build with the command2017-03-29T12:41:16.696 [ERROR] mvn -rf :beam-runners-sparkchannel stoppedSetting status of e2967d9 to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8885/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

@staslev
Copy link
Contributor Author

staslev commented Mar 29, 2017

retest this please

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 70.19% when pulling 7d7a0a8 on staslev:BEAM-1713-SparkRuntimeContext-captured-in-StateSpecFunctions into 99056df on apache:master.

@asfbot
Copy link

asfbot commented Mar 29, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8884/
--none--

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 70.154% when pulling 7d7a0a8 on staslev:BEAM-1713-SparkRuntimeContext-captured-in-StateSpecFunctions into 99056df on apache:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 70.15% when pulling 7d7a0a8 on staslev:BEAM-1713-SparkRuntimeContext-captured-in-StateSpecFunctions into 99056df on apache:master.

@asfbot
Copy link

asfbot commented Mar 29, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8886/
--none--

@asfbot
Copy link

asfbot commented Mar 29, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8890/
--none--

@asfbot
Copy link

asfbot commented Mar 29, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/1428/
--none--

@asfgit asfgit closed this in 2a40534 Mar 30, 2017
@staslev staslev deleted the BEAM-1713-SparkRuntimeContext-captured-in-StateSpecFunctions branch March 30, 2017 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants