Fix for #22951 w/ GroupIntoBatchesOverride fix #24463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es size limit implementation.
|
Run Dataflow ValidatesRunner |
|
Run Dataflow Streaming ValidatesRunner |
|
Run Java Dataflow V2 ValidatesRunner |
|
Run Java Dataflow V2 ValidatesRunner Streaming |
|
CC: @nbali |
lukecwik
changed the title
|
Assigning reviewers. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
stop reviewer notifications |
|
Stopping reviewer notifications for this pull request: requested by reviewer |
|
Run Java PreCommit |
4 similar comments
|
Run Java PreCommit |
|
Run Java PreCommit |
|
Run Java PreCommit |
|
Run Java PreCommit |
prodriguezdefino
pushed a commit
to prodriguezdefino/beam-pabs
that referenced
this pull request
Dec 6, 2022
* Fix for apache#22951 * Fix Dataflow GroupIntoBatchesOverride to match updated GroupIntoBatches size limit implementation. Co-authored-by: Balázs Németh <nbali@users.noreply.github.com>
lostluck
pushed a commit
to lostluck/beam
that referenced
this pull request
Dec 22, 2022
* Fix for apache#22951 * Fix Dataflow GroupIntoBatchesOverride to match updated GroupIntoBatches size limit implementation. Co-authored-by: Balázs Németh <nbali@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this is #22953 with a patch to fix the GroupIntoBatchesOverride implementation so that the Dataflow tests pass.
Closes #22951
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.