Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-59] Register standard FileSystems wherever we register IOChannelFactories #2569

Closed
wants to merge 1 commit into from
Closed

[BEAM-59] Register standard FileSystems wherever we register IOChannelFactories #2569

wants to merge 1 commit into from

Conversation

dhalperi
Copy link
Contributor

Additionally, drop an unnecessary use of GcsOptions inPipelineRunner.

R: @jbonofre

@dhalperi
[BEAM-59] Register standard FileSystems wherever we register IOChanne…
88cc651 
…lFactories

Additionally, drop an unnecessary use of `GcsOptions` in
`PipelineRunner`.
@jbonofre
Copy link
Member

Thanks ! I'm taking a look.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 70.662% when pulling 88cc651 on dhalperi:register-filesystems into c52ce7c on apache:master.

jbonofre
jbonofre approved these changes Apr 18, 2017
View reviewed changes
Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (testing with a custom filesystem), I gonna merge.

@asfgit asfgit closed this in e556858 Apr 18, 2017
@dhalperi dhalperi deleted the register-filesystems branch April 20, 2017 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbonofre jbonofre jbonofre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dhalperi @jbonofre @coveralls