Basic Opeartor Metric Support For Data Shuffle (GBK and Combine Per Key) Operators for Samza Runner #26649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey) Operators for Samza Runner
|
R: @xinyuiscool please take a look |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
xinyuiscool
reviewed
May 12, 2023
runners/samza/src/main/java/org/apache/beam/runners/samza/metrics/SamzaInputGBKMetricOp.java
Outdated
Show resolved
Hide resolved
runners/samza/src/main/java/org/apache/beam/runners/samza/metrics/SamzaOutputGBKMetricOp.java
Outdated
Show resolved
Hide resolved
.../samza/src/main/java/org/apache/beam/runners/samza/metrics/SamzaTransformMetricRegistry.java
Show resolved
Hide resolved
xinyuiscool
reviewed
May 16, 2023
| if (isDataShuffleTransform(urn)) { | ||
| return new SamzaGBKMetricOp<>( | ||
| pValue, transformName, opType, samzaTransformMetricRegistry); | ||
| } | ||
| return new SamzaInputMetricOp(pValue, transformName, samzaTransformMetricRegistry); |
There was a problem hiding this comment.
Similar to GBKMetricOp, can we also merge SamzaInputMetricOp and SamzaOutputMetricOp into one?
There was a problem hiding this comment.
Yup it did make sense to simplify this, done!
|
Run Java PreCommit |
Sanil15
added a commit
to Sanil15/beam
that referenced
this pull request
May 22, 2023
…ey) Operators for Samza Runner (apache#26649)
Sanil15
added a commit
to linkedin/beam
that referenced
this pull request
May 22, 2023
…ey) Operators for Samza Runner (apache#26649)
Dippatel98
pushed a commit
to Dippatel98/beam
that referenced
this pull request
Jun 5, 2023
…ey) Operators for Samza Runner (apache#26649)
bullet03
pushed a commit
to akvelon/beam
that referenced
this pull request
Aug 11, 2023
…ey) Operators for Samza Runner (apache#26649)
cushon
pushed a commit
to cushon/beam
that referenced
this pull request
May 24, 2024
…ey) Operators for Samza Runner (apache#26649)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#26456
Summary
Tests
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.