[BEAM-59] Add FileSystems#matchNewResource #2728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @peihe @ssisk @davorbonaci |
dhalperi
force-pushed
the
filesystem-matchnewresource
branch
2 times, most recently
from
eb33428
to
12e6d90
Compare
|
Update the TODO / documentation https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/io/fs/ResourceId.java#L30 |
dhalperi
force-pushed
the
filesystem-matchnewresource
branch
2 times, most recently
from
d0cc6ce
to
cf85719
Compare
|
Changes Unknown when pulling cf85719 on dhalperi:filesystem-matchnewresource into ** on apache:master**. |
The new FileSystems API needs a way to generate a ResourceId for a resource that does not exist. This does not come up in sources, because we typically are just matching existing files. However, sinks need the ability to reference a new directory (say, in order to create it). Couldn't think of anything better than a simple function that says "treat this string as a full resource path with the specified type", which is what FileSystems#matchNewResource is.
dhalperi
force-pushed
the
filesystem-matchnewresource
branch
from
cf85719
to
f93a277
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new FileSystems API needs a way to generate a ResourceId for a
resource that does not exist. This does not come up in sources, because
we typically are just matching existing files. However, sinks need the
ability to reference a new directory (say, in order to create it).
Couldn't think of anything better than a simple function that says
"treat this string as a full resource path with the specified type",
which is what FileSystems#matchNewResource is.