Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made changes to build and test multi-arch Beam SDK container images #27311

Closed
wants to merge 72 commits into from

Conversation

celeste-zeng
Copy link
Contributor

@celeste-zeng celeste-zeng commented Jun 29, 2023

The pull request adds the following changes:

  • Adds the -Ppush-containers build parameter to push and save multi-arch containers as a manifest list.
  • Explicitly adds tensorflow-cpu-aws as an additional base image requirement for Python containers when building the ARM components of the multi-arch container images.
  • Configures the suite of Python ValidatesContainer tests against the Dataflow runner so that the containers built are multi-arch and being used to test.

Related issues:
Explicitly install tensorflow-cpu-aws: tensorflow/tensorflow#60751
Save multi-arch images: #26902

Design doc: https://docs.google.com/document/d/1ikbEJNsFH1D9HqiMqiVyyMlNpDgSqxXK22nUoetzW6I/edit?usp=sharing

@tvalentyn
Copy link
Contributor

Run Python Dataflow ValidatesContainer

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #27311 (e3d321b) into master (7bfead0) will decrease coverage by 0.01%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #27311      +/-   ##
==========================================
- Coverage   70.89%   70.89%   -0.01%     
==========================================
  Files         860      860              
  Lines      104635   104635              
==========================================
- Hits        74184    74183       -1     
- Misses      28898    28899       +1     
  Partials     1553     1553              
Flag Coverage Δ
go 53.37% <ø> (ø)
python 80.00% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@celeste-zeng celeste-zeng changed the title Made changes to build and test multi-arch Beam Python SDK containger images Made changes to build and test multi-arch Beam Python SDK container images Jun 29, 2023
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.
R: @lostluck for label go.
R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@celeste-zeng
Copy link
Contributor Author

Run Python Dataflow ValidatesContainer

@celeste-zeng
Copy link
Contributor Author

Run Python Dataflow ValidatesContainer

@github-actions github-actions bot added java and removed java labels Jul 11, 2023
@github-actions github-actions bot added java and removed java labels Jul 11, 2023
…tCommit_Java_Examples_Dataflow_V2 test suite for diff Java versions.
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

Reminder, please take a look at this pr: @tvalentyn @lostluck @Abacn

@celeste-zeng
Copy link
Contributor Author

Changes were broken down into other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants