[BEAM-775] Remove Aggregators from StatefulDoFn runner #2744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabloem
force-pushed
the
remove-statefuldofn
branch
2 times, most recently
from
ea23bf4
to
70d1f39
Compare
|
r: @dhalperi |
pabloem
force-pushed
the
remove-statefuldofn
branch
from
bcc6894
to
374d92e
Compare
|
Relaunching tests. @dhalperi ready to merge after tests pass. |
|
Straightforward LGTM – very nice; running tests in #2817 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on PR 2718.