Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-1871] Hide internal implementation details of how we create a DefaultBucket for GCP Temp Location #2747

Closed
wants to merge 1 commit into from

Conversation

lukecwik
Copy link
Member

Moved relevant contents of GcpProjectUtil and DefaultProject into GcpOptions.GcpTempLocation

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

…efaultBucket for GCP Temp Location

Moved relevant contents of GcpProjectUtil and DefaultProject into GcpOptions.GcpTempLocation
@@ -33,14 +29,4 @@
+ "https://cloud.google.com/resource-manager/ for details on CloudResourceManager.")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept this as a marker interface incase we do add transport level options for CRM.
It also gives clarity as to what pipeline options it relies on.

@lukecwik
Copy link
Member Author

R: @dhalperi @tgroh

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 69.794% when pulling 270dfc2 on lukecwik:thin_sdk_core3 into fdf2de9 on apache:master.

@dhalperi
Copy link
Contributor

dhalperi commented Apr 27, 2017

LGTM, high-level scan only.

Analysis: Looks like a lot of moves. Spot-checked a few things and checked out.

4 files deleted, so -80 lines of license doesn't quite explain -200 lines overall. But another 10-15 of imports, plus some condensed testing does.

@dhalperi
Copy link
Contributor

self-merge at will.

@asfgit asfgit closed this in f29444b Apr 29, 2017
andrewsmartin added a commit to spotify/scio that referenced this pull request May 30, 2017
andrewsmartin added a commit to spotify/scio that referenced this pull request May 30, 2017
andrewsmartin added a commit to spotify/scio that referenced this pull request May 30, 2017
andrewsmartin added a commit to spotify/scio that referenced this pull request May 31, 2017
nevillelyh pushed a commit to spotify/scio that referenced this pull request Jun 1, 2017
nevillelyh pushed a commit to spotify/scio that referenced this pull request Jun 5, 2017
nevillelyh pushed a commit to spotify/scio that referenced this pull request Jun 6, 2017
nevillelyh pushed a commit to spotify/scio that referenced this pull request Jun 6, 2017
nevillelyh pushed a commit to spotify/scio that referenced this pull request Jun 12, 2017
nevillelyh pushed a commit to spotify/scio that referenced this pull request Jun 13, 2017
andrewsmartin added a commit to spotify/scio that referenced this pull request Jun 13, 2017
nevillelyh pushed a commit to spotify/scio that referenced this pull request Jun 14, 2017
nevillelyh pushed a commit to spotify/scio that referenced this pull request Jun 15, 2017
nevillelyh pushed a commit to spotify/scio that referenced this pull request Jun 15, 2017
nevillelyh pushed a commit to spotify/scio that referenced this pull request Jun 15, 2017
nevillelyh pushed a commit to spotify/scio that referenced this pull request Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants