New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-1871] Hide internal implementation details of how we create a DefaultBucket for GCP Temp Location #2747
Conversation
…efaultBucket for GCP Temp Location Moved relevant contents of GcpProjectUtil and DefaultProject into GcpOptions.GcpTempLocation
@@ -33,14 +29,4 @@ | |||
+ "https://cloud.google.com/resource-manager/ for details on CloudResourceManager.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept this as a marker interface incase we do add transport level options for CRM.
It also gives clarity as to what pipeline options it relies on.
LGTM, high-level scan only. Analysis: Looks like a lot of moves. Spot-checked a few things and checked out. 4 files deleted, so -80 lines of license doesn't quite explain -200 lines overall. But another 10-15 of imports, plus some condensed testing does. |
self-merge at will. |
Note: logic copied from apache/beam#2803 and apache/beam#2747
Note: logic copied from apache/beam#2803 and apache/beam#2747
Note: logic copied from apache/beam#2803 and apache/beam#2747
Note: logic copied from apache/beam#2803 and apache/beam#2747
Note: logic copied from apache/beam#2803 and apache/beam#2747
Note: logic copied from apache/beam#2803 and apache/beam#2747
Note: logic copied from apache/beam#2803 and apache/beam#2747
Note: logic copied from apache/beam#2803 and apache/beam#2747
Note: logic copied from apache/beam#2803 and apache/beam#2747
Note: logic copied from apache/beam#2803 and apache/beam#2747
Note: logic copied from apache/beam#2803 and apache/beam#2747
Note: logic copied from apache/beam#2803 and apache/beam#2747
Note: logic copied from apache/beam#2803 and apache/beam#2747
Note: logic copied from apache/beam#2803 and apache/beam#2747
Note: logic copied from apache/beam#2803 and apache/beam#2747
Note: logic copied from apache/beam#2803 and apache/beam#2747
Moved relevant contents of GcpProjectUtil and DefaultProject into GcpOptions.GcpTempLocation
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull request
mvn clean verify
. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>
in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.