[BEAM-2183] Archetypes: fix build order #2916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalperi
force-pushed
the
maven-archetype-build-order
branch
from
39a2a61
to
fc62855
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @davorbonaci
CC: @jbonofre
The archetypes in sdks/java/maven-archetypes/ compile and run tests for source code that depends on various Beam modules. The dependencies are reflected in the *inner pom.xml inside src/main/resources/archetype-resources/pom.xml.
The outer module needs to have the same Beam dependencies to force the Maven Reactor build order to process those modules first. Otherwise, a simple run of mvn install (e.g.,) , even without parallelism, may run the maven-archetypes step before it install the dependent modules. This means that the code may run against a previous nightly snapshot or other non-up-to-date-copy of those modules.