Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-2161] support string operators #2919

Closed
wants to merge 2 commits into from
Closed

[BEAM-2161] support string operators #2919

wants to merge 2 commits into from

Conversation

xumingming
Copy link
Contributor

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling bc0506b on xumingming:BEAM-2161-support-string-operators into ** on apache:DSL_SQL**.

mingmxu
mingmxu reviewed May 7, 2017
View reviewed changes
Copy link

@mingmxu mingmxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R: @xumingmin

mingmxu
mingmxu reviewed May 7, 2017
View reviewed changes
...java/org/apache/beam/dsls/sql/interpreter/operator/string/BeamSqlPositionExpressionTest.java Outdated
import org.junit.Test;

/**
* Created by xumingmingv on 5/5/17.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls update JavaDoc here

@mingmxu
Copy link

mingmxu commented May 7, 2017

overall LGTM,

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 168cebf on xumingming:BEAM-2161-support-string-operators into ** on apache:DSL_SQL**.

@jbonofre
Copy link
Member

jbonofre commented May 9, 2017

R: @jbonofre

jbonofre
jbonofre approved these changes May 9, 2017
View reviewed changes
Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm merging.

@xumingming xumingming force-pushed the BEAM-2161-support-string-operators branch from 168cebf to b40c5b4 Compare May 9, 2017 08:37
@xumingming
Copy link
Contributor Author

Conflict resolved.

@jbonofre
Copy link
Member

jbonofre commented May 9, 2017

Thanks, waiting the end of Jenkins before merging.

asfgit pushed a commit that referenced this pull request May 9, 2017
@jbonofre
[BEAM-2161] This closes #2919
3e678a7
@jbonofre
Copy link
Member

jbonofre commented May 9, 2017

Merged on DSL_SQL branch. You can close this PR. Thanks !

@xumingming xumingming closed this May 9, 2017
@xumingming xumingming deleted the BEAM-2161-support-string-operators branch May 9, 2017 12:20
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b40c5b4 on xumingming:BEAM-2161-support-string-operators into ** on apache:DSL_SQL**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbonofre jbonofre jbonofre approved these changes

@mingmxu mingmxu mingmxu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xumingming @coveralls @mingmxu @jbonofre