Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-2206] Move pipelineOptions into options modules #2925

Closed
wants to merge 1 commit into from

Conversation

sb2nov
Copy link
Contributor

@sb2nov sb2nov commented May 5, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify.
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@sb2nov
Copy link
Contributor Author

sb2nov commented May 5, 2017

R: @aaltay PTAL

@sb2nov
Copy link
Contributor Author

sb2nov commented May 5, 2017

@sb2nov
Copy link
Contributor Author

sb2nov commented May 5, 2017

Run Python PostCommit

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 718b309 on sb2nov:BEAM-move-pipeline-options into ** on apache:master**.

@sb2nov sb2nov force-pushed the BEAM-move-pipeline-options branch from 718b309 to 0585b17 Compare May 7, 2017 20:55
@sb2nov sb2nov changed the title Move pipelineOptions into options modules [BEAM-2206] Move pipelineOptions into options modules May 7, 2017
@sb2nov
Copy link
Contributor Author

sb2nov commented May 7, 2017

Run Python PostCommit

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 70.574% when pulling 0585b17 on sb2nov:BEAM-move-pipeline-options into dabad1a on apache:master.

@sb2nov
Copy link
Contributor Author

sb2nov commented May 7, 2017

R: @aaltay PTAL

Made the changes temporarily backwards compatible and I'll remove all of them in a separate PR.

@aaltay
Copy link
Member

aaltay commented May 8, 2017

LGTM

@asfgit asfgit closed this in 604c2f5 May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants