Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade protobuf version to remediate a leak. #29255

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

tvalentyn
Copy link
Contributor

Fixes: #28246

@tvalentyn
Copy link
Contributor Author

cc: @damccorm

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #29255 (0b798d7) into master (3934117) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #29255      +/-   ##
==========================================
- Coverage   38.32%   38.28%   -0.04%     
==========================================
  Files         688      689       +1     
  Lines      101879   101986     +107     
==========================================
+ Hits        39043    39046       +3     
- Misses      61257    61361     +104     
  Partials     1579     1579              
Flag Coverage Δ
python 29.88% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sdks/python/setup.py 0.00% <ø> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@damccorm
Copy link
Contributor

damccorm commented Nov 2, 2023

Run Python_Coverage PreCommit

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once checks pass

Copy link
Contributor

github-actions bot commented Nov 2, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm damccorm merged commit f803451 into apache:master Nov 2, 2023
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: [Python SDK] Memory leak in 2.47.0 - 2.51.0 SDKs.
2 participants