Bugfix/update avro version #29390
Bugfix/update avro version #29390
Conversation
# Conflicts: # CHANGES.md
Create gradle task and github actions config for GCS using this.
…tests Feature/automate performance tests
…tests fix call to gradle
…tests run on hosted runner for testing
…tests add additional checkout
…tests add destination for triggered tests
…tests move env variables to correct location
…tests try uploading against separate dataset
…tests try without a user
…tests update branch checkout, try to view the failure log
…tests run on failure
…tests update to use correct BigQuery instance
…tests convert to matrix
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #29390 +/- ##
==========================================
- Coverage 38.28% 37.82% -0.46%
==========================================
Files 694 690 -4
Lines 102255 101081 -1174
==========================================
- Hits 39147 38237 -910
+ Misses 61518 61257 -261
+ Partials 1590 1587 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
retest this please |
|
Run Spotless PreCommit |
… deprecated for 9 years, and recently lost public access
|
run avro precommit |
|
Run PostCommit_Java_Avro_Versions |
|
the java precommit appears to be running :sdk:avro:extensions:test, which isn't a 'good' path. We have 4 avro versions we test, and just running test will fail. This is confusing because the java precommit appears to exclude extensions/avro |
|
Run Python_Runners PreCommit |
|
@johnjcasey Please, use |
| @@ -301,7 +301,7 @@ enum TestEnum { | |||
| .set( | |||
| "decimalValue", | |||
| new Conversions.DecimalConversion() | |||
| .toBytes(bd, Schema.create(Schema.Type.NULL), LogicalTypes.decimal(1, 1))) | |||
| .toBytes(bd, Schema.create(Schema.Type.NULL), LogicalTypes.decimal(2, 1))) | |||
There was a problem hiding this comment.
Why it was changed?
| @@ -262,8 +262,7 @@ private static TableFieldSchema fieldDescriptorFromAvroField(Schema.Field field) | |||
| elementType.getType() != Schema.Type.UNION, | |||
| "Multiple non-null union types are not supported."); | |||
| TableFieldSchema unionFieldSchema = | |||
| fieldDescriptorFromAvroField( | |||
| new Schema.Field(field.name(), elementType, field.doc(), field.defaultVal())); | |||
| fieldDescriptorFromAvroField(new Schema.Field(field.name(), elementType, field.doc())); | |||
There was a problem hiding this comment.
Is it going to be compiled successfully with previous Avro versions?
There was a problem hiding this comment.
In this case, the code here just is about trying to determine schema information. the default value doesn't appear to be needed
|
If we don't run |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.