Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-2213] Convert Executor Services to use Daemon Threads #2961

Closed
wants to merge 1 commit into from

Conversation

tgroh
Copy link
Member

@tgroh tgroh commented May 8, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify.
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

This will cause the DirectRunner to automatically shut down when the
worker threads are shut down.

Merged to master in #2954

This will cause the DirectRunner to automatically shut down when the
worker threads are shut down.
@tgroh
Copy link
Member Author

tgroh commented May 8, 2017

R: @davorbonaci

Copy link
Member

@davorbonaci davorbonaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b69a9b8 on tgroh:executor_daemons_rls into ** on apache:release-2.0.0**.

asfgit pushed a commit that referenced this pull request May 8, 2017
@tgroh
Copy link
Member Author

tgroh commented May 8, 2017

Merged into release branch.

@tgroh tgroh closed this May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants