Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periodically send perworkermetric updates on the WorkerMessages api. #30074

Closed
wants to merge 2 commits into from

Conversation

JayajP
Copy link
Contributor

@JayajP JayajP commented Jan 22, 2024

If EnablePerWorkerMetrics is True, then StreamingDataflowWorker will periodically extract PerWorkerMetric updates and send them on the WorkerMessages API. This happens in StreamingDataflowWorker::sendWorkerMessage.

Currently, we only support sending BigQuerySink metrics on this channel.

Additionally, when we extract counter updates we will take note of counters that are zero-valued, counters that have been zero-valued for more than 5 minutes will be removed from the underlying metrics storage (the StreamingStepMetricsContainer::perWorkerCounters map). This allows us to create counters based on bigquery table ids, which can be dynamically set with dynamic destinations.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@JayajP JayajP marked this pull request as ready for review January 23, 2024 03:42
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@JayajP JayajP marked this pull request as draft January 23, 2024 17:08
Copy link
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 24, 2024
Copy link
Contributor

github-actions bot commented Apr 1, 2024

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant