Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused it-gcp and it-jdbc modules #30207

Closed
wants to merge 2 commits into from

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Feb 3, 2024

Part of #30206

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Feb 3, 2024
@Abacn
Copy link
Contributor Author

Abacn commented Feb 3, 2024

Besides the reasons in #30206 , for it-gcp itself, it was found in Beam 2.54.0rc1 validation that some changes need to be made in it-gcp component itself: https://github.com/GoogleCloudPlatform/DataflowTemplates/pull/1313/files#diff-ca10da4b6f0b454247e31d288a7c6492c0dcb1bb3c78eaab028f2c7716876802. If it-gcp were in Beam repo, it then had to trigger build another rc just for the fix of it-gcp module.

@Abacn Abacn marked this pull request as draft February 3, 2024 14:39
Copy link
Contributor

github-actions bot commented Apr 4, 2024

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 4, 2024
Copy link
Contributor

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant