Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-2241] Renames some python classes and functions that were unnecessarily public #3041

Closed

Conversation

chamikaramj
Copy link
Contributor

Adds a note to documentation of classes that are public but should be only used internally by the SDK (non-user facing classes).

Marks some of the modules as experimental.

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify.
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

…lic.

Adds a note to documentation of classes that are public but should be only used internally by the SDK (non-user facing classes).

Marks some of the modules as experimental.
@chamikaramj
Copy link
Contributor Author

R: @aaltay

cc: @davorbonaci

@aaltay
Copy link
Member

aaltay commented May 10, 2017

LGTM

asfgit pushed a commit that referenced this pull request May 10, 2017
@aaltay
Copy link
Member

aaltay commented May 10, 2017

Merged, please manually close.

@chamikaramj
Copy link
Contributor Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants