Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove protobuf and http-client dependency from Dataflow runner #3072

Closed
wants to merge 1 commit into from

Conversation

vikkyrk
Copy link
Contributor

@vikkyrk vikkyrk commented May 11, 2017

runners/google-cloud-dataflow

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify.
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 70.191% when pulling 8be5466 on vikkyrk:pbf into a39960b on apache:master.

@vikkyrk
Copy link
Contributor Author

vikkyrk commented May 11, 2017

Unrelated failure.
R: @lukecwik

@vikkyrk
Copy link
Contributor Author

vikkyrk commented May 11, 2017

Run Java PostCommit

@lukecwik
Copy link
Member

LGTM
Consider as a cherry pick onto the release which optionally may go in

@asfgit asfgit closed this in ff589c7 May 11, 2017
asfgit pushed a commit that referenced this pull request May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants